Skip to content

Commit 849784d

Browse files
thiyaguk09thiyaguk09
committed
test: skip system tests involving ACL and public IAM roles
1 parent caac389 commit 849784d

1 file changed

Lines changed: 67 additions & 81 deletions

File tree

‎handwritten/storage/system-test/storage.ts‎

Lines changed: 67 additions & 81 deletions
Original file line numberDiff line numberDiff line change
@@ -235,22 +235,20 @@ describe('storage', function () {
235235
);
236236
});
237237

238-
it('should get access controls', async function () {
239-
const [metadata] = await bucket.getMetadata();
240-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
241-
this.skip();
242-
}
243-
238+
/**
239+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
240+
* Currently disabled because uniform bucket-level access disables ACLs.
241+
*/
242+
it.skip('should get access controls', async () => {
244243
const accessControls = await bucket.acl.get();
245244
assert(Array.isArray(accessControls));
246245
});
247246

248-
it('should add entity to default access controls', async function () {
249-
const [metadata] = await bucket.getMetadata();
250-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
251-
this.skip();
252-
}
253-
247+
/**
248+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
249+
* Currently disabled because uniform bucket-level access disables ACLs.
250+
*/
251+
it.skip('should add entity to default access controls', async () => {
254252
const [accessControl] = await bucket.acl.default.add({
255253
entity: USER_ACCOUNT,
256254
role: storage.acl.OWNER_ROLE,
@@ -265,22 +263,20 @@ describe('storage', function () {
265263
await bucket.acl.default.delete({entity: USER_ACCOUNT});
266264
});
267265

268-
it('should get default access controls', async function () {
269-
const [metadata] = await bucket.getMetadata();
270-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
271-
this.skip();
272-
}
273-
266+
/**
267+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
268+
* Currently disabled because uniform bucket-level access disables ACLs.
269+
*/
270+
it.skip('should get default access controls', async () => {
274271
const accessControls = await bucket.acl.default.get();
275272
assert(Array.isArray(accessControls));
276273
});
277274

278-
it('should grant an account access', async function () {
279-
const [metadata] = await bucket.getMetadata();
280-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
281-
this.skip();
282-
}
283-
275+
/**
276+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
277+
* Currently disabled because uniform bucket-level access disables ACLs.
278+
*/
279+
it.skip('should grant an account access', async () => {
284280
const [accessControl] = await bucket.acl.add({
285281
entity: USER_ACCOUNT,
286282
role: storage.acl.OWNER_ROLE,
@@ -295,12 +291,11 @@ describe('storage', function () {
295291
await bucket.acl.delete(opts);
296292
});
297293

298-
it('should update an account', async function () {
299-
const [metadata] = await bucket.getMetadata();
300-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
301-
this.skip();
302-
}
303-
294+
/**
295+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
296+
* Currently disabled because uniform bucket-level access disables ACLs.
297+
*/
298+
it.skip('should update an account', async () => {
304299
const [accessControl] = await bucket.acl.add({
305300
entity: USER_ACCOUNT,
306301
role: storage.acl.OWNER_ROLE,
@@ -375,12 +370,11 @@ describe('storage', function () {
375370
}
376371
});
377372

378-
it('should make files private', async function () {
379-
const [metadata] = await bucket.getMetadata();
380-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
381-
this.skip();
382-
}
383-
373+
/**
374+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
375+
* Currently disabled because uniform bucket-level access disables ACLs.
376+
*/
377+
it.skip('should make files private', async () => {
384378
await Promise.all(
385379
['a', 'b', 'c'].map(text => createFileWithContentPromise(text)),
386380
);
@@ -411,12 +405,11 @@ describe('storage', function () {
411405
await file.delete();
412406
});
413407

414-
it('should get access controls', async function () {
415-
const [metadata] = await bucket.getMetadata();
416-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
417-
this.skip();
418-
}
419-
408+
/**
409+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
410+
* Currently disabled because uniform bucket-level access disables ACLs.
411+
*/
412+
it.skip('should get access controls', async () => {
420413
const [accessControls] = await file.acl.get();
421414
assert(Array.isArray(accessControls));
422415
});
@@ -426,12 +419,11 @@ describe('storage', function () {
426419
assert.strictEqual(typeof (file as any).default, 'undefined');
427420
});
428421

429-
it('should grant an account access', async function () {
430-
const [metadata] = await bucket.getMetadata();
431-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
432-
this.skip();
433-
}
434-
422+
/**
423+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
424+
* Currently disabled because uniform bucket-level access disables ACLs.
425+
*/
426+
it.skip('should grant an account access', async () => {
435427
const [accessControl] = await file.acl.add({
436428
entity: USER_ACCOUNT,
437429
role: storage.acl.OWNER_ROLE,
@@ -445,12 +437,11 @@ describe('storage', function () {
445437
await file.acl.delete({entity: USER_ACCOUNT});
446438
});
447439

448-
it('should update an account', async function () {
449-
const [metadata] = await bucket.getMetadata();
450-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
451-
this.skip();
452-
}
453-
440+
/**
441+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
442+
* Currently disabled because uniform bucket-level access disables ACLs.
443+
*/
444+
it.skip('should update an account', async () => {
454445
const [accessControl] = await file.acl.add({
455446
entity: USER_ACCOUNT,
456447
role: storage.acl.OWNER_ROLE,
@@ -479,12 +470,11 @@ describe('storage', function () {
479470
await file.acl.delete({entity: 'allUsers'});
480471
});
481472

482-
it('should make a file private', async function () {
483-
const [metadata] = await bucket.getMetadata();
484-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
485-
this.skip();
486-
}
487-
473+
/**
474+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
475+
* Currently disabled because uniform bucket-level access disables ACLs.
476+
*/
477+
it.skip('should make a file private', async () => {
488478
const validateMakeFilePrivateRejects = (err: ApiError) => {
489479
assert.strictEqual(err.code, 404);
490480
assert.strictEqual(err!.errors![0].reason, 'notFound');
@@ -557,12 +547,11 @@ describe('storage', function () {
557547
});
558548
});
559549

560-
it('should make a file private from a resumable upload', async function () {
561-
const [metadata] = await bucket.getMetadata();
562-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
563-
this.skip();
564-
}
565-
550+
/**
551+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
552+
* Currently disabled because uniform bucket-level access disables ACLs.
553+
*/
554+
it.skip('should make a file private from a resumable upload', async () => {
566555
const validateMakeFilePrivateRejects = (err: ApiError) => {
567556
assert.strictEqual((err as ApiError)!.code, 404);
568557
assert.strictEqual((err as ApiError).errors![0].reason, 'notFound');
@@ -1214,12 +1203,11 @@ describe('storage', function () {
12141203
describe('preserves bucket/file ACL over uniform bucket-level access on/off', () => {
12151204
beforeEach(createBucket);
12161205

1217-
it('should preserve default bucket ACL', async function () {
1218-
const [metadata] = await bucket.getMetadata();
1219-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
1220-
this.skip();
1221-
}
1222-
1206+
/**
1207+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
1208+
* Currently disabled because uniform bucket-level access disables ACLs.
1209+
*/
1210+
it.skip('should preserve default bucket ACL', async () => {
12231211
await bucket.acl.default.update(customAcl);
12241212
const [aclBefore] = await bucket.acl.default.get();
12251213

@@ -1238,12 +1226,11 @@ describe('storage', function () {
12381226
}
12391227
}).timeout(UNIFORM_ACCESS_TIMEOUT);
12401228

1241-
it('should preserve file ACL', async function () {
1242-
const [metadata] = await bucket.getMetadata();
1243-
if (metadata.iamConfiguration?.uniformBucketLevelAccess?.enabled) {
1244-
this.skip();
1245-
}
1246-
1229+
/**
1230+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
1231+
* Currently disabled because uniform bucket-level access disables ACLs.
1232+
*/
1233+
it.skip('should preserve file ACL', async () => {
12471234
const file = bucket.file(`file-${crypto.randomUUID()}`);
12481235
await file.save('data', {resumable: false});
12491236

@@ -3205,9 +3192,8 @@ describe('storage', function () {
32053192
});
32063193

32073194
/**
3208-
* TODO: Re-enable once the test environment allows public IAM roles.
3209-
* Currently disabled to avoid 403 errors when adding 'allUsers' or
3210-
* 'allAuthenticatedUsers' permissions.
3195+
* TODO: Re-enable once the test environment is configured without uniform bucket-level access.
3196+
* Currently disabled because uniform bucket-level access disables ACLs.
32113197
*/
32123198
it.skip('should respect predefined Acl at file#copy', async () => {
32133199
const opts = {destination: 'CloudLogo'};

0 commit comments

Comments
 (0)