fix: hmacKey fix

thiyaguk09 · thiyaguk09 · commit ae9abaddabe1 · 2026-04-27T07:48:49.000Z
diff --git a/handwritten/storage/src/file.ts b/handwritten/storage/src/file.ts
@@ -3307,11 +3307,10 @@ class File extends ServiceObject<File, FileMetadata> {
             cb(null, false);
             return;
           }
-
           cb(err);
         },
       )
-      .catch(err => callback!(err));
+      .catch(err => cb(err));
   }
 
   makePrivate(
diff --git a/handwritten/storage/src/hmacKey.ts b/handwritten/storage/src/hmacKey.ts
@@ -354,7 +354,7 @@ export class HmacKey extends ServiceObject<HmacKey, HmacKeyMetadata> {
       storageTransport: storage.storageTransport,
       parent: storage,
       id: accessId,
-      baseUrl: `/projects/${projectId}/hmacKeys`,
+      baseUrl: `/storage/v1/projects/${projectId}/hmacKeys`,
       methods,
     });
 
diff --git a/handwritten/storage/src/resumable-upload.ts b/handwritten/storage/src/resumable-upload.ts
@@ -1208,6 +1208,8 @@ export class Upload extends Writable {
         code: resp.status.toString(),
         message: resp.statusText,
         name: resp.statusText,
+        config: resp.config,
+        response: resp,
       } as GaxiosError)
     ) {
       void this.attemptDelayedRetry(resp);
diff --git a/handwritten/storage/src/storage.ts b/handwritten/storage/src/storage.ts
@@ -1224,7 +1224,7 @@ export class Storage {
       .makeRequest<HmacKeyResourceResponse>(
         {
           method: 'POST',
-          url: `/projects/${projectId}/hmacKeys`,
+          url: `/storage/v1/projects/${projectId}/hmacKeys`,
           queryParameters: query as unknown as StorageQueryParameters,
           retry: false,
           responseType: 'json',
@@ -1488,7 +1488,7 @@ export class Storage {
         items: HmacKeyMetadata[];
       }>(
         {
-          url: `/projects/${projectId}/hmacKeys`,
+          url: `/storage/v1/projects/${projectId}/hmacKeys`,
           responseType: 'json',
           queryParameters: query as unknown as StorageQueryParameters,
           method: 'GET',
diff --git a/handwritten/storage/system-test/kitchen.ts b/handwritten/storage/system-test/kitchen.ts
@@ -99,7 +99,7 @@ describe('resumable-upload', () => {
     // see: https://cloud.google.com/storage/docs/exponential-backoff:
     const ms = Math.pow(2, retries) * 1000 + Math.random() * 2000;
     console.info(`retrying "${title}" in ${ms}ms`);
-    setTimeout(() => done, ms);
+    setTimeout(() => done(), ms);
   }
 
   it('should work', done => {
diff --git a/handwritten/storage/system-test/storage.ts b/handwritten/storage/system-test/storage.ts
diff --git a/handwritten/storage/test/index.ts b/handwritten/storage/test/index.ts

Original file line number	Diff line number	Diff line change
`@@ -3307,11 +3307,10 @@ class File extends ServiceObject<File, FileMetadata> {`
`3307`	`3307`	`cb(null, false);`
`3308`	`3308`	`return;`
`3309`	`3309`	`}`
`3310`		`-`
`3311`	`3310`	`cb(err);`
`3312`	`3311`	`},`
`3313`	`3312`	`)`
`3314`		`- .catch(err => callback!(err));`
	`3313`	`+ .catch(err => cb(err));`
`3315`	`3314`	`}`
`3316`	`3315`
`3317`	`3316`	`makePrivate(`
Original file line number	Diff line number	Diff line change
`@@ -99,7 +99,7 @@ describe('resumable-upload', () => {`
`99`	`99`	`// see: https://cloud.google.com/storage/docs/exponential-backoff:`
`100`	`100`	`const ms = Math.pow(2, retries) * 1000 + Math.random() * 2000;`
`101`	`101`	console.info(`retrying "${title}" in ${ms}ms`);
`102`		`- setTimeout(() => done, ms);`
	`102`	`+ setTimeout(() => done(), ms);`
`103`	`103`	`}`
`104`	`104`
`105`	`105`	`it('should work', done => {`