Skip to content

Commit bc82004

Browse files
authored
chore: remove broken sample scripts and dead test configs (googleapis#8767)
1 parent 7929948 commit bc82004

6 files changed

Lines changed: 8 additions & 31 deletions

File tree

handwritten/firestore/.eslintrc.json

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
{
2+
"root": true,
23
"extends": "./node_modules/gts",
34
"overrides": [
45
{

handwritten/firestore/.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,3 +14,4 @@ system-test/*key.json
1414
.DS_Store
1515
package-lock.json
1616
__pycache__
17+
*.tsbuildinfo

handwritten/firestore/dev/.nycrc

Lines changed: 0 additions & 24 deletions
This file was deleted.

handwritten/firestore/dev/system-test/pipeline.ts

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7406,7 +7406,9 @@ describe.skipClassic('Pipeline search', () => {
74067406
});
74077407

74087408
const isRestTest = isRest(firestore);
7409-
const expectedErrorPattern = isRestTest ? /"code": 400/ : /3 INVALID_ARGUMENT.*/;
7409+
const expectedErrorPattern = isRestTest
7410+
? /"code": 400/
7411+
: /3 INVALID_ARGUMENT.*/;
74107412
await expect(ppl.execute()).to.be.rejectedWith(expectedErrorPattern);
74117413
});
74127414
});
@@ -7459,7 +7461,9 @@ describe.skipClassic('Pipeline search', () => {
74597461

74607462
snapshot = await ppl.execute();
74617463
expect(snapshot.results.length).to.equal(1);
7462-
expect(['solTacos', 'eastsideTacos']).to.include(snapshot.results[0].id);
7464+
expect(['solTacos', 'eastsideTacos']).to.include(
7465+
snapshot.results[0].id,
7466+
);
74637467
});
74647468
});
74657469

handwritten/firestore/dev/test/mocha.opts

Lines changed: 0 additions & 3 deletions
This file was deleted.

handwritten/firestore/package.json

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,6 @@
5151
"system-test:nightly": "FIRESTORE_TARGET_BACKEND=nightly FIRESTORE_DATABASE_ID=enterprise RUN_ENTERPRISE_TESTS=yes GCLOUD_PROJECT=firestore-sdk-nightly mocha build/system-test --timeout 1200000",
5252
"system-test:emulator": "concurrently -p \"[{name}]\" -n \"grpc,rest,enterprise-grpc,enterprise-rest\" -c \"cyan,magenta,blue,yellow\" \"npm:system-test:emulator:grpc\" \"npm:system-test:emulator:rest\" \"npm:system-test:enterprise:emulator:grpc\" \"npm:system-test:enterprise:emulator:rest\"",
5353
"presystem-test": "npm run compile",
54-
"samples-test": "npm link && cd samples/ && npm link ../ && npm test && cd ../",
5554
"conformance": "mocha build/conformance",
5655
"preconformance": "npm run compile",
5756
"test-only": "c8 mocha build/test",
@@ -63,7 +62,6 @@
6362
"postcompile": "node scripts/init-directories.js && cp -r dev/protos build && cp dev/src/v1beta1/*.json build/src/v1beta1/ && cp dev/src/v1/*.json build/src/v1/ && cp dev/conformance/test-definition.proto build/conformance && cp dev/conformance/conformance-tests/*.json build/conformance/conformance-tests && minifyProtoJson",
6463
"fix": "gts fix",
6564
"prepare": "npm run compile",
66-
"prelint": "cd samples; npm link ../; npm install",
6765
"precompile": "gts clean"
6866
},
6967
"dependencies": {

0 commit comments

Comments
 (0)