test: update ipFilter test configuration and refine bucket metadata test assertions

Author: thiyaguk09

handwritten/storage/system-test/storage.ts

@@ -121,7 +121,7 @@ describe('storage', function () {
       bindings: [
         {
           role: 'roles/pubsub.editor',
-          members: ['allUsers'],
+          members: ['serviceAccount:service-920946329098@gs-project-accounts.iam.gserviceaccount.com'],
         },
       ],
     });
@@ -1290,7 +1290,7 @@ describe('storage', function () {
   });
 
   describe('bucket metadata', () => {
-    describe('ipFilter', () => {
+    describe.only('ipFilter', () => {
       let ipFilterBucket: Bucket;
 
       before(async () => {
@@ -1302,7 +1302,7 @@ describe('storage', function () {
         await ipFilterBucket.delete().catch(() => { });
       });
 
-      it('should enable and set ipFilter', async () => {
+      it('should set ipFilter', async () => {
         const metadata: BucketMetadata = {
           ipFilter: {
             mode: 'Disabled',
@@ -1339,7 +1339,7 @@ describe('storage', function () {
         assert.deepStrictEqual(meta.ipFilter, metadata.ipFilter);
       });
 
-      it('should clear ipFilter', async () => {
+      it('should clear allowedIpCidrRanges', async () => {
         const [getMeta] = await ipFilterBucket.getMetadata();
         assert.strictEqual(getMeta.ipFilter?.mode, 'Disabled');
         assert.deepStrictEqual(

handwritten/storage/test/bucket.ts

@@ -3551,6 +3551,17 @@ describe('Bucket', () => {
       it('should get ipFilter', done => {
         const ipFilter = {
           mode: 'Enabled',
+          publicNetworkSource: {
+            allowedIpCidrRanges: ['192.168.1.1/32'],
+          },
+          vpcNetworkSources: [
+            {
+              network: 'projects/my-project/global/networks/my-vpc',
+              allowedIpCidrRanges: ['10.0.0.0/8'],
+            },
+          ],
+          allowAllServiceAgentAccess: true,
+          allowCrossOrgVpcs: true,
         };
 
         bucket.getMetadata = () => {