fix: cleanup IAM policy payloads, refactor file upload options, and migrate deprecated ACL system tests to the testbench approach.

Author: thiyaguk09

handwritten/storage/package.json

@@ -93,7 +93,7 @@
     "@types/mime": "3.0.0",
     "@types/mocha": "^10.0.10",
     "@types/mockery": "^1.4.33",
-    "@types/node": "^24.0.0",
+    "@types/node": "^24.13.3",
     "@types/node-fetch": "^2.6.12",
     "@types/proxyquire": "^1.3.31",
     "@types/sinon": "^17.0.4",
@@ -117,4 +117,4 @@
     "yargs": "^17.7.2"
   },
   "homepage": "https://github.com/googleapis/google-cloud-node/tree/main/handwritten/storage"
-}
+}

handwritten/storage/src/file.ts

@@ -4548,9 +4548,10 @@ class File extends ServiceObject<File, FileMetadata> {
    */
   startSimpleUpload_(
     dup: Duplexify,
-    options: CreateWriteStreamOptionsInternal = {},
+    options: CreateWriteStreamOptions = {},
   ): void {
-    options.metadata ??= {};
+    const opts = options as CreateWriteStreamOptionsInternal;
+    opts.metadata ??= {};
 
     const apiEndpoint = this.storage.apiEndpoint;
     const bucketName = this.bucket.name;
@@ -4562,7 +4563,7 @@ class File extends ServiceObject<File, FileMetadata> {
         uploadType: 'multipart',
       },
       url,
-      invocationId: options.invocationId,
+      invocationId: opts.invocationId,
       [GCCL_GCS_CMD_KEY]: options[GCCL_GCS_CMD_KEY],
       method: 'POST',
       responseType: 'json',
@@ -4606,12 +4607,12 @@ class File extends ServiceObject<File, FileMetadata> {
     reqOpts.multipart = [
       {
         headers: new Headers({'Content-Type': 'application/json'}),
-        content: JSON.stringify(options.metadata),
+        content: JSON.stringify(opts.metadata),
       },
       {
         headers: new Headers({
           'Content-Type':
-            options.metadata.contentType || 'application/octet-stream',
+            opts.metadata?.contentType || 'application/octet-stream',
         }),
         content: writeStream,
       },

handwritten/storage/src/iam.ts

@@ -350,8 +350,12 @@ class Iam {
       SetPolicyCallback
     >(optionsOrCallback, callback);
 
+    const policyToSet = {...policy};
+    delete (policyToSet as any).headers;
+    delete (policyToSet as any).status;
+
     let maxRetries;
-    if (policy.etag === undefined) {
+    if (policyToSet.etag === undefined) {
       maxRetries = 0;
     }
 
@@ -361,7 +365,7 @@ class Iam {
           method: 'PUT',
           url: `/storage/v1/b/${this.bucket.name}/iam`,
           maxRetries,
-          body: JSON.stringify(policy),
+          body: JSON.stringify(policyToSet),
           headers: {'Content-Type': 'application/json'},
           queryParameters: options as unknown as StorageQueryParameters,
         },

handwritten/storage/system-test/install.ts

@@ -21,7 +21,7 @@ describe('pack-n-play tests', () => {
     await packNTest({
       sample: {
         description: 'Should be able to import the storage library in ESM',
-        cjs: readFileSync('./system-test/fixtures/index-esm.js').toString(),
+        ts: readFileSync('./system-test/fixtures/index-esm.js').toString(),
       },
     });
   });