feat(storage): support copying CSEK-encrypted files to non-CSEK destinations - #26
Open
thiyaguk09 wants to merge 6 commits into
Open
feat(storage): support copying CSEK-encrypted files to non-CSEK destinations#26thiyaguk09 wants to merge 6 commits into
thiyaguk09 wants to merge 6 commits into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for null encryption keys to allow copying CSEK-encrypted files to standard non-CSEK destinations. The review identifies a critical bug in the copy logic where the source file's encryption key is mutated and the destination file is left in an inconsistent state by bypassing setEncryptionKey. Feedback also suggests correcting the corresponding unit tests to avoid asserting on this buggy behavior and to use the proper setter method instead of manually assigning dummy properties.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
thiyaguk09
requested review from
gurusai-voleti,
mahendra-google and
shubhangi-google
June 29, 2026 11:52
shubhangi-google
approved these changes
Jun 29, 2026
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
2 times, most recently
from
July 10, 2026 12:30
76c3932 to
ea8daaa
Compare
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
5 times, most recently
from
July 27, 2026 06:48
a74b4bf to
657755f
Compare
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
4 times, most recently
from
July 30, 2026 04:48
2e98b7c to
a55fd61
Compare
…pis#9028) Update pinned action version comments to match exact SemVer tags (e.g., # v6.0.3, # v4.3.1, # v6.4.0) to satisfy online zizmor scanner.
…typescript (googleapis#9029) ## Description Upgrade the gapic-generator-typescript to node version 22. ## Impact Ensures users upgrade their runtime to Node 22 and don't encounter problems due to legacy Node 18 issues. ## Changes Node was upgraded to version 22 in two package.json files and then `npm run baseline` was run. Just the following files were updated: core/generator/gapic-generator-typescript/templates/cjs/typescript_gapic/package.json core/generator/gapic-generator-typescript/templates/esm/typescript_gapic/package.json Then in core/generator/gapic-generator-typescript we ran the following command: `npm run baseline` ## Next steps Next we are going to upgrade all the packages in the root `packages` directory to separate concerns about the packages and the gapic-typescript-generator.
…SEK and fix copy behavior for non-encrypted destinations
…r conflicts during file copy operations
…t instead of file request
thiyaguk09
force-pushed
the
feat/7351-copy-csek-to-unencrypted
branch
from
July 31, 2026 13:49
a55fd61 to
265194c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕