chore(architecture): split guardrails from packaging fix

Author: thodson-usgs

CONTRIBUTING.md

@@ -79,51 +79,30 @@ Please do not combine multiple feature enhancements into a single pull request.
 Before you submit a pull request, check that it meets these guidelines:
 
 1. If the pull request adds or modifies package functionality, unit tests
-   should be written to test the new functionality.
-2. If the pull request adds or modifies functionality, update the documentation
-   or function docstrings that describe it.
-3. The pull request should work for Python 3.10 and later. Refer to the
-   [Python package workflow](https://github.com/DOI-USGS/dataretrieval-python/blob/main/.github/workflows/python-package.yml)
-   for the versions and operating systems currently tested by CI.
-4. Build-related changes should preserve the installed-wheel smoke test; tests
-   run from a source checkout are not sufficient to prove package contents.
-5. Architecturally significant changes should update the
-   [architecture documentation](docs/source/architecture/index.rst), add or
-   supersede an ADR, and adjust the corresponding fitness function.
+   should be written to test the new functionality
+2. If the pull request adds or modifies functionality, the documentation should
+   be updated. To do so, either add or modify a functions docstring which will
+   automatically become part of the API documentation
+3. The pull request should work for Python 3.9 and later - refer to the
+   [python-package.yml file](https://github.com/DOI-USGS/dataretrieval-python/blob/main/.github/workflows/python-package.yml)
+   for the latest versions of Python being tested by the continuous integration
+   pipelines. This will be checked automatically by the CI pipelines once the
+   pull request is opened.
 
 ### Coding Standards and Style
 
-The continuous integration and pre-commit configurations enforce formatting,
-linting, and strict type checking. Run the relevant checks before opening a PR:
-
-```bash
-ruff check .
-ruff format --check .
-mypy
-coverage run -m pytest tests/
-coverage report -m
-```
-
-For documentation changes, install `.[doc,nldi]` and run `make html` from
-`docs/`. The broader `make docs` target also runs doctests and network-dependent
-link checking.
+Note that coding standards and style as described below are strong suggestions,
+the `dataretrieval` project does not strictly lint or enforce style guidelines
+via any automated processes or pipelines.
 
 #### Style
 
-* Follow the [PEP8 style guidelines](https://peps.python.org/pep-0008/).
-* The public interface should emphasize functions over classes; classes can and
-  should be used internally and in tests.
-* Group public download functions by data portal. For example, modern Water
-  Data functions belong in `dataretrieval.waterdata`; legacy NWIS functions
-  remain quarantined in `dataretrieval.nwis` during deprecation.
-* Preserve the dependency direction documented in
-  [`docs/source/architecture`](docs/source/architecture/index.rst): public
-  facades depend on service/protocol adapters, which depend on stable shared
-  policy and infrastructure. Shared OGC code must not import service adapters,
-  and modern modules must not depend on legacy NWIS.
-* Treat underscore-prefixed helpers as implementation details. Existing
-  cross-package uses are documented variances, not extension points for new
-  code.
+* Attempt to write code following the [PEP8 style guidelines](https://peps.python.org/pep-0008/) as much as possible
+* The public interface should emphasize functions over classes; however, classes
+  can and should be used internally and in tests
+* Functions for downloading data from a specific web portal must be grouped
+  within their own submodule
+  * For example, all NWIS functions are located at `dataretrieval.nwis`
 
 #### Docstrings
 * Docstrings should follow the [numpy standard](https://numpydoc.readthedocs.io/en/v1.5.0/format.html):

NEWS.md

@@ -1,5 +1,3 @@
-**08/02/2026:** Fixed source-distribution and wheel package discovery so the `dataretrieval.ogc` and `dataretrieval.waterdata` subpackages are included in installed artifacts. CI now builds and installs the wheel outside the source checkout before importing the core service modules. Added an architecture baseline, initial decision records, and executable dependency-direction guardrails for the existing modular-monolith boundaries.
-
 **06/23/2026:** **Breaking change (1.2.0):** the minimum supported Python is now **3.10** (`requires-python = ">=3.10"`). 3.9 support was already effectively broken — the `waterdata` module's dependencies (`anyio`, the test stack) require 3.10+, and the `waterdata` test modules already skipped on <3.10. `anyio` is now declared as a direct dependency (it is imported directly by `waterdata`), and the CI/ruff/mypy targets move to 3.10. Also fully removed the deprecated `variable_info` metadata property: the `NWIS_Metadata` override only warned and returned `None` (it relied on the defunct `get_pmcodes`), and the `BaseMetadata` abstract is gone too since nothing implemented it — accessing `.variable_info` now raises `AttributeError`. `site_info` is unaffected.
 
 **06/23/2026:** **Breaking change (1.2.0):** removed the `nadp` module and the deprecated `samples` module ahead of the 1.2.0 release. `nadp` was deprecated on 05/01/2026 — NADP is not a USGS data source, so retrieve NADP data directly from https://nadp.slh.wisc.edu/. The `samples.get_usgs_samples` shim (a deprecated forward to the modern getter) is gone; use `waterdata.get_samples()` instead. `import dataretrieval.nadp` / `import dataretrieval.samples` now raise `ModuleNotFoundError`.