Revert get_results dataProfile changes (covered by PR DOI-USGS#250)

The simplify pass added `TypeError(msg, msg)` -> `ValueError(single_msg)`
fixes to `get_results`'s two `dataProfile` validators. PR DOI-USGS#250 ("Fix
get_results: preserve user-supplied WQX3.0 dataProfile") restructures
the same code more thoroughly and addresses the same exception-shape
bug as a side effect, so this PR should not duplicate that work.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Author: thodson-usgs

dataretrieval/wqp.py

@@ -131,9 +131,9 @@ def get_results(
             "dataProfile" in kwargs
             and kwargs["dataProfile"] not in result_profiles_legacy
         ):
-            raise ValueError(
-                f"dataProfile {kwargs['dataProfile']} is not a legacy profile. "
-                f"Valid options are {result_profiles_legacy}."
+            raise TypeError(
+                f"dataProfile {kwargs['dataProfile']} is not a legacy profile.",
+                f"Valid options are {result_profiles_legacy}.",
             )
 
         url = wqp_url("Result")
@@ -143,9 +143,9 @@ def get_results(
             "dataProfile" in kwargs
             and kwargs["dataProfile"] not in result_profiles_wqx3
         ):
-            raise ValueError(
-                f"dataProfile {kwargs['dataProfile']} is not a valid WQX3.0 "
-                f"profile. Valid options are {result_profiles_wqx3}."
+            raise TypeError(
+                f"dataProfile {kwargs['dataProfile']} is not a valid WQX3.0"
+                f"profile. Valid options are {result_profiles_wqx3}.",
             )
         else:
             kwargs["dataProfile"] = "fullPhysChem"

tests/wqp_test.py

@@ -243,15 +243,3 @@ def test_what_organizations_legacy_false_warns(requests_mock):
         what_organizations(
             statecode="US:34", characteristicName="Chloride", legacy=False
         )
-
-
-def test_get_results_invalid_legacy_dataprofile_raises_value_error():
-    """Invalid legacy dataProfile -> ValueError with single readable message."""
-    with pytest.raises(ValueError, match="is not a legacy profile"):
-        get_results(dataProfile="not_a_real_profile")
-
-
-def test_get_results_invalid_wqx3_dataprofile_raises_value_error():
-    """Invalid WQX3.0 dataProfile -> ValueError with single readable message."""
-    with pytest.raises(ValueError, match="is not a valid WQX3.0 profile"):
-        get_results(legacy=False, dataProfile="not_a_real_profile")