Skip to content

Commit e843861

Browse files
thodson-usgsclaude
andcommitted
Use 'is not None' guards so empty-string sources still validate
Per copilot review on PR DOI-USGS#246. The previous truthiness guard skipped validation for empty-string feature_source/data_source, letting bad inputs build invalid URLs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 parent d183bb5 commit e843861

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

dataretrieval/nldi.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -256,10 +256,10 @@ def get_features(
256256
# validate the feature source and comid
257257
_validate_feature_source_comid(feature_source, feature_id, comid)
258258
# validate the data source
259-
if data_source:
259+
if data_source is not None:
260260
_validate_data_source(data_source)
261261
# validate feature source
262-
if feature_source:
262+
if feature_source is not None:
263263
_validate_data_source(feature_source)
264264
# validate the navigation mode
265265
if navigation_mode:

0 commit comments

Comments
 (0)