Update super_sstable_reader.go

[sebheitzmann]

The contains of the readers already handle the "tombstone" case.

[thomasjungblut]

do you mind to add a unit test for this too? I wonder why this just passes :D

[sebheitzmann]

I will check if the test cover this

[thomasjungblut]

added this as part of 44b5b67

thanks for fixing this as well, I'll see whether we need some more test coverage around this right now

[sebheitzmann]

Just a question :

go-sstables/sstables/sstable_merger.go

Line 41 in d00463f

func (m SSTableMerger) Merge(iterators []SSTableMergeIteratorContext, writer SSTableStreamWriterI) (err error) {

go-sstables/sstables/sstable_merger.go

Line 120 in d00463f

func (m SSTableMerger) MergeCompactIterator(iterators []SSTableMergeIteratorContext, reduce ReduceFunc) (SSTableIteratorI, error) {

There is two merge method. I don't really understand the difference. And I don't understand the need of the context.

[thomasjungblut]

of course. Merge just merges the given iterators into a single file, so it will have duplicated key entries with their respective values.

MergeCompactIterator returns an iterator that merges and runs the reduce function on the same keys, so the iterator always returns a key and all the matching values.

[sebheitzmann]

Thanks for the response. But what about the context ?

[thomasjungblut]

The context is to understand which sstable the iterator originated from, so you can do selection based on this too, e.g. check out: https://github.com/thomasjungblut/go-sstables/blob/main/sstables/super_sstable_reader.go#L57-L63