Include login link in Easee authentication error messages (#35)

* Initial plan

* Add ApplicationOptions and update Easee error message with login link

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

* Add Application.BaseUrl to development settings

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

* Update documentation to include Application.BaseUrl configuration and login link feature

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

* Use port 5271 from launch config and make login link clickable in Telegram

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

* Switch from HTML to MarkdownV2 for clickable links in Telegram

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

* Send login URL as separate plain text message instead of formatted link

Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: thomasneuberger <23504477+thomasneuberger@users.noreply.github.com>

Author: Copilot

.github/copilot-instructions.md

@@ -127,6 +127,7 @@ public static class Bootstrap
 - Configuration sections match the domain (e.g., `HomeAssistant`, `Telegram`, `SmartHome`)
 - Store sensitive data externally (marked as `<set externally>` in appsettings.json)
 - Use user secrets for development, environment variables for production
+- **URL Configuration**: When configuring URLs in appsettings files that reference services in the same repository, always use the same port as defined in the launch configuration (`Properties/launchSettings.json`). For example, if `launchSettings.json` specifies `"applicationUrl": "http://localhost:5271"`, then `Application.BaseUrl` in appsettings should also use port `5271`.
 
 ### Logging
 

TgHomeBot.Api/Program.cs

@@ -29,6 +29,7 @@
 });
 
 builder.Services.AddOptions<FileStorageOptions>().Configure(options => builder.Configuration.GetSection("FileStorage").Bind(options));
+builder.Services.AddOptions<ApplicationOptions>().Configure(options => builder.Configuration.GetSection("Application").Bind(options));
 builder.Services.AddOptions<SerilogLogFileProvider.SerilogOptions>().Configure(options => builder.Configuration.GetSection("Serilog").Bind(options));
 
 builder.Services.AddHomeAssistant(builder.Configuration);

TgHomeBot.Api/appsettings.Development.json

@@ -16,6 +16,9 @@
     }
   },
   "AllowedHosts": "*",
+  "Application": {
+    "BaseUrl": "http://localhost:5271"
+  },
   "SmartHome": {
     "MonitoredDevices": []
   },

TgHomeBot.Api/appsettings.json

@@ -16,6 +16,9 @@
     }
   },
   "AllowedHosts": "*",
+  "Application": {
+    "BaseUrl": "http://localhost:5271"
+  },
   "SmartHome": {
     "MonitoredDevices": []
   },

TgHomeBot.Charging.Easee/EaseeConnector.cs

@@ -20,6 +20,7 @@ internal class EaseeConnector : IChargingConnector
     private readonly HttpClient _httpClient;
     private readonly FileStorageOptions _fileStorageOptions;
     private readonly IUserAliasService _userAliasService;
+    private readonly ApplicationOptions _applicationOptions;
     private readonly string _tokenFilePath;
     private EaseeTokenData? _tokenData;
     private readonly object _lock = new();
@@ -29,11 +30,13 @@ public EaseeConnector(
         IHttpClientFactory httpClientFactory,
         IOptions<EaseeOptions> easeeOptions,
         IOptions<FileStorageOptions> fileStorageOptions,
+        IOptions<ApplicationOptions> applicationOptions,
         IUserAliasService userAliasService)
     {
         _logger = logger ?? throw new ArgumentNullException(nameof(logger));
         _httpClient = httpClientFactory?.CreateClient() ?? throw new ArgumentNullException(nameof(httpClientFactory));
         _fileStorageOptions = fileStorageOptions?.Value ?? throw new ArgumentNullException(nameof(fileStorageOptions));
+        _applicationOptions = applicationOptions?.Value ?? throw new ArgumentNullException(nameof(applicationOptions));
         _userAliasService = userAliasService ?? throw new ArgumentNullException(nameof(userAliasService));
 
         var options = easeeOptions?.Value ?? throw new ArgumentNullException(nameof(easeeOptions));
@@ -372,7 +375,7 @@ private async Task EnsureAuthenticatedAsync(CancellationToken cancellationToken)
             var refreshed = await RefreshTokenAsync(cancellationToken);
             if (!refreshed)
             {
-                throw new InvalidOperationException("Not authenticated with Easee API. Please authenticate first.");
+                throw new InvalidOperationException("Nicht mit Easee API authentifiziert. Bitte anmelden.");
             }
         }
     }

TgHomeBot.Charging.Easee/README.md

@@ -11,10 +11,13 @@ This project provides integration with the Easee API for electric vehicle chargi
 
 ## Configuration
 
-Add the following section to your `appsettings.json`:
+Add the following sections to your `appsettings.json`:
 
 ```json
 {
+  "Application": {
+    "BaseUrl": "http://localhost:5271"
+  },
   "Easee": {
     "BaseUrl": "https://api.easee.com"
   },
@@ -24,6 +27,10 @@ Add the following section to your `appsettings.json`:
 }
 ```
 
+- **Application.BaseUrl**: The base URL where your TgHomeBot application is hosted. This is used to generate login links in error messages. Use the same port as defined in `launchSettings.json` (default: 5271).
+- **Easee.BaseUrl**: The Easee API endpoint (typically `https://api.easee.com`)
+- **FileStorage.Path**: Directory where the authentication token will be stored
+
 The authentication token will be stored in `{FileStorage.Path}/easee-token.json`.
 
 ## Authentication
@@ -34,6 +41,25 @@ Navigate to `/Easee/Login` to access the authentication page where you can enter
 
 **Important**: The credentials are not stored - they are only used to authenticate with the Easee API. The resulting access token and refresh token are stored persistently.
 
+### Authentication Errors
+
+When using the Telegram bot commands (e.g., `/monthlyreport`, `/detailedreport`) without valid authentication, the bot will respond with two messages:
+
+1. An error message:
+```
+❌ Fehler beim Abrufen der Ladevorgänge:
+Nicht mit Easee API authentifiziert. Bitte anmelden.
+```
+
+2. A follow-up message with the login URL:
+```
+http://localhost:5271/Easee/Login
+```
+
+The URL in the second message can be clicked to open the login page directly in the browser.
+
+This makes it easy to authenticate directly from the Telegram error message.
+
 ### Programmatic Authentication
 
 You can also authenticate programmatically using the `IChargingConnector` service:

TgHomeBot.Common.Contract/ApplicationOptions.cs

@@ -0,0 +1,12 @@
+namespace TgHomeBot.Common.Contract;
+
+/// <summary>
+/// Options for application-wide configuration
+/// </summary>
+public class ApplicationOptions
+{
+    /// <summary>
+    /// The base URL where the application is hosted (e.g., "http://localhost:5000" or "https://myapp.example.com")
+    /// </summary>
+    public required string BaseUrl { get; set; }
+}

TgHomeBot.Notifications.Telegram/Commands/DetailedReportCommand.cs

@@ -1,15 +1,18 @@
 using System.Globalization;
 using MediatR;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
 using Telegram.Bot;
 using Telegram.Bot.Types;
 using TgHomeBot.Charging.Contract.Requests;
+using TgHomeBot.Common.Contract;
 
 namespace TgHomeBot.Notifications.Telegram.Commands;
 
-internal class DetailedReportCommand(IServiceProvider serviceProvider) : ICommand
+internal class DetailedReportCommand(IServiceProvider serviceProvider, IOptions<ApplicationOptions> applicationOptions) : ICommand
 {
     private const int MaxTelegramMessageLength = 4000;
+    private readonly ApplicationOptions _applicationOptions = applicationOptions.Value;
 
     public string Name => "/detailedreport";
 
@@ -31,6 +34,15 @@ public async Task ProcessMessage(Message message, ITelegramBotClient client, Can
             await client.SendTextMessageAsync(new ChatId(message.Chat.Id),
                 $"❌ Fehler beim Abrufen der Ladevorgänge:\n{result.ErrorMessage}",
                 cancellationToken: cancellationToken);
+            
+            // If it's an authentication error, send the login URL as a separate message
+            if (result.ErrorMessage?.Contains("Nicht mit Easee API authentifiziert") == true)
+            {
+                var loginUrl = $"{_applicationOptions.BaseUrl.TrimEnd('/')}/Easee/Login";
+                await client.SendTextMessageAsync(new ChatId(message.Chat.Id),
+                    loginUrl,
+                    cancellationToken: cancellationToken);
+            }
             return;
         }
 

TgHomeBot.Notifications.Telegram/Commands/MonthlyReportCommand.cs

@@ -1,14 +1,18 @@
 using MediatR;
 using Microsoft.Extensions.DependencyInjection;
+using Microsoft.Extensions.Options;
 using Telegram.Bot;
 using Telegram.Bot.Types;
 using TgHomeBot.Charging.Contract.Requests;
 using TgHomeBot.Charging.Contract.Services;
+using TgHomeBot.Common.Contract;
 
 namespace TgHomeBot.Notifications.Telegram.Commands;
 
-internal class MonthlyReportCommand(IServiceProvider serviceProvider) : ICommand
+internal class MonthlyReportCommand(IServiceProvider serviceProvider, IOptions<ApplicationOptions> applicationOptions) : ICommand
 {
+    private readonly ApplicationOptions _applicationOptions = applicationOptions.Value;
+
     public string Name => "/monthlyreport";
 
     public string Description => "Monatliche Zusammenfassung des geladenen Stroms";
@@ -30,6 +34,15 @@ public async Task ProcessMessage(Message message, ITelegramBotClient client, Can
             await client.SendTextMessageAsync(new ChatId(message.Chat.Id),
                 $"❌ Fehler beim Abrufen der Ladevorgänge:\n{result.ErrorMessage}",
                 cancellationToken: cancellationToken);
+            
+            // If it's an authentication error, send the login URL as a separate message
+            if (result.ErrorMessage?.Contains("Nicht mit Easee API authentifiziert") == true)
+            {
+                var loginUrl = $"{_applicationOptions.BaseUrl.TrimEnd('/')}/Easee/Login";
+                await client.SendTextMessageAsync(new ChatId(message.Chat.Id),
+                    loginUrl,
+                    cancellationToken: cancellationToken);
+            }
             return;
         }