Improve SmartHomeMonitorWatcherTask: CancellationToken propagation, sync, and logging

[Copilot]

Addresses review feedback on the SmartHomeMonitorWatcherTask PR: missing cancellation support, race conditions in EnsureMonitorIsRunning, unhandled Unknown state, and noisy logging.

Changes

• ISmartHomeConnector — EnsureMonitorIsRunning now accepts a CancellationToken

• HomeAssistantConnector.EnsureMonitorIsRunning

  • Propagates CancellationToken instead of CancellationToken.None
  • Treats MonitorState.Unknown like Idle — attempts StartMonitoringAsync rather than silently returning false
  • Wraps the read-and-start logic in _semaphore to prevent races with CreateMonitorAsync

• SmartHomeMonitorWatcherTask.ExecuteAsync

  • Checks cancellationToken.ThrowIfCancellationRequested() before work
  • Passes cancellationToken through to the connector
  • Downgrades success log from Information → Debug; uses Warning on failure

public async Task ExecuteAsync(CancellationToken cancellationToken)
{
    cancellationToken.ThrowIfCancellationRequested();

    var isRunning = await smartHomeConnector.EnsureMonitorIsRunning(cancellationToken).ConfigureAwait(false);

    if (!isRunning)
        logger.LogWarning("Smart Home Monitor is not running and could not be started.");
    else
        logger.LogDebug("Smart Home Monitor is running.");
}

---

🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.

[Copilot]

Pull request overview

This PR refines the Smart Home monitor “watchdog” flow by propagating cancellation tokens through the connector API, synchronizing monitor start checks to avoid races, and reducing log noise in the scheduled watcher task.

Changes:

• Updated ISmartHomeConnector.EnsureMonitorIsRunning to accept a CancellationToken.
• Improved HomeAssistantConnector.EnsureMonitorIsRunning to propagate cancellation, handle Unknown state like Idle, and synchronize access with a semaphore.
• Updated SmartHomeMonitorWatcherTask to honor cancellation early, pass the token through, and adjust logging levels (success → Debug, failure → Warning).

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
TgHomeBot.SmartHome.HomeAssistant/HomeAssistantConnector.cs	Adds token-aware, semaphore-synchronized monitor “ensure running” logic and treats Unknown as startable.
TgHomeBot.SmartHome.Contract/ISmartHomeConnector.cs	Updates connector contract to include cancellation in EnsureMonitorIsRunning.
TgHomeBot.Scheduling/Tasks/SmartHomeMonitorWatcherTask.cs	Propagates cancellation and adjusts logging to be less noisy on success.

Comments suppressed due to low confidence (1)

TgHomeBot.SmartHome.HomeAssistant/HomeAssistantConnector.cs:98

• The broad catch (Exception) here will also catch OperationCanceledException from _semaphore.WaitAsync(cancellationToken) / StartMonitoringAsync(cancellationToken), log it as an error, and return false. That breaks cancellation propagation (e.g., scheduler shutdown) and can cause spurious warning/error logs. Handle OperationCanceledException separately (rethrow when cancellationToken.IsCancellationRequested) and only log/return false for non-cancellation failures.

        catch (Exception e)
        {
            logger.LogError(e, "Error ensuring Home Assistant monitor is running");
            return false;
        }

[Copilot]

StartMonitoringAsync can perform network I/O and retry loops (potentially taking a long time). Because it is awaited while holding _semaphore, other callers that need the same semaphore (e.g., CreateMonitorAsync used by /check via GetMonitorStateRequestHandler) can be blocked for the entire connection/retry duration. Consider limiting the semaphore scope to just reading _smartHomeMonitor/State and deciding whether to start, then call StartMonitoringAsync outside the lock (it’s already idempotent when the WebSocket is open).