fix: Fix deadlock issues in async processors - #307
Merged
Conversation
- Fix TaskCompletionSource not being set on exceptions in ProcessOrderedItemAsync Previously, if _taskSelector threw an exception, no TaskCompletionSource was added to the ordering dictionary, causing infinite waits. Now always add TCS first, then set result/exception appropriately. - Replace GetAwaiter().GetResult() with Task.Run + timeout in Dispose methods Prevents synchronization context deadlocks in UI/ASP.NET contexts by running async disposal on thread pool with 30-second timeout. - Add proper exception handling to channel.Writer.Complete() calls Ensures channels are properly completed even when exceptions occur during producer/consumer task execution. Uses finally blocks to guarantee completion regardless of where exceptions are thrown. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
thomhurst
enabled auto-merge
August 9, 2025 00:16
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix TaskCompletionSource not being set on exceptions in ProcessOrderedItemAsync Previously, if _taskSelector threw an exception, no TaskCompletionSource was added to the ordering dictionary, causing infinite waits. Now always add TCS first, then set result/exception appropriately.
Replace GetAwaiter().GetResult() with Task.Run + timeout in Dispose methods Prevents synchronization context deadlocks in UI/ASP.NET contexts by running async disposal on thread pool with 30-second timeout.
Add proper exception handling to channel.Writer.Complete() calls Ensures channels are properly completed even when exceptions occur during producer/consumer task execution. Uses finally blocks to guarantee completion regardless of where exceptions are thrown.
🤖 Generated with Claude Code