test: make allocation assertion deterministic#348
Merged
Conversation
Greptile SummaryThis PR makes the wrapper allocation test deterministic. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "test: isolate wrapper allocation measure..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GC.GetAllocatedBytesForCurrentThread()instead of process-wide live heap size.Root cause
GC.GetTotalMemory(false)includes unrelated allocations from concurrently running TUnit tests and target frameworks. That made the fixed 200 KB threshold nondeterministic even when wrapper behavior was unchanged.Test plan
dotnet test TomLonghurst.EnumerableAsyncProcessor.sln -c Releasepassesgit diff --checkCloses #346