Skip to content

fix(ci): fail on broken examples#349

Merged
thomhurst merged 1 commit into
mainfrom
fix/pr-347-review-followup
Jul 21, 2026
Merged

fix(ci): fail on broken examples#349
thomhurst merged 1 commit into
mainfrom
fix/pr-347-review-followup

Conversation

@thomhurst

@thomhurst thomhurst commented Jul 21, 2026

Copy link
Copy Markdown
Owner

Summary

  • Make example builds throw on nonzero exit codes so packaging cannot proceed after compilation failure.
  • Correct the disposal example's leak description after eager result materialization.

Context

These changes address both Greptile review threads on #347. That PR auto-merged while the fixes were being tested, so this focused follow-up preserves the reviewed corrections without reverting subsequently merged work.

Test plan

  • dotnet build EnumerableAsyncProcessor.Example/EnumerableAsyncProcessor.Example.csproj -c Release
  • dotnet build EnumerableAsyncProcessor.Pipeline/EnumerableAsyncProcessor.Pipeline.csproj -c Release
  • Full suite passed 1,074/1,074 with this exact two-file review-fix delta before splitting it onto current main
  • git diff --check

Follow-up to #347

@greptile-apps

greptile-apps Bot commented Jul 21, 2026

Copy link
Copy Markdown

Greptile Summary

This PR makes failed example builds stop the packaging workflow and clarifies the disposal example.

  • Enables exceptions for nonzero example-build exit codes.
  • Updates the resource-leak description after eager result materialization.

Confidence Score: 5/5

This looks safe to merge.

  • No blocking issues found in the changed code.
  • The packaging module depends on the example-build module, so a thrown build failure stops the dependent workflow.
  • The disposal example change affects documentation only.

Important Files Changed

Filename Overview
EnumerableAsyncProcessor.Pipeline/Modules/BuildExampleProjectsModule.cs Passes explicit execution options to each example build so compilation failures stop dependent packaging stages.
EnumerableAsyncProcessor.Example/DisposalExample.cs Corrects a comment about resources left uncleaned when the processor is not disposed.

Reviews (1): Last reviewed commit: "fix(ci): fail on broken examples" | Re-trigger Greptile

@thomhurst
thomhurst merged commit e7cae8d into main Jul 21, 2026
5 checks passed
@thomhurst
thomhurst deleted the fix/pr-347-review-followup branch July 21, 2026 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@thomhurst