Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion EnumerableAsyncProcessor.Example/DisposalExample.cs
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ private static async Task<IReadOnlyList<int>> ProblematicPatternAsync(int[] inpu
}

// 🔥 RESOURCE LEAK: The processor goes out of scope without being disposed,
// potentially leaving tasks running and resources uncleaned
// leaving its disposal resources uncleaned
return results;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using ModularPipelines.Git.Extensions;
using ModularPipelines.Models;
using ModularPipelines.Modules;
using ModularPipelines.Options;

namespace EnumerableAsyncProcessor.Pipeline.Modules;

Expand All @@ -14,6 +15,10 @@ public class BuildExampleProjectsModule : Module<List<CommandResult>>
CancellationToken cancellationToken)
{
var results = new List<CommandResult>();
var executionOptions = new CommandExecutionOptions
{
ThrowOnNonZeroExitCode = true,
};

foreach (var exampleProjectFile in context
.Git().RootDirectory
Expand All @@ -24,7 +29,7 @@ public class BuildExampleProjectsModule : Module<List<CommandResult>>
{
ProjectSolution = exampleProjectFile.Path,
Configuration = "Release",
}, cancellationToken: cancellationToken));
}, executionOptions: executionOptions, cancellationToken: cancellationToken));
}

return results;
Expand Down
Loading