Add cancellation-aware async selectors#354
Merged
Merged
Conversation
Greptile SummaryThis PR adds cancellation-aware async selectors across the processor APIs. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "fix: await async selector cleanup" | Re-trigger Greptile |
Add token-aware SelectAsync and ForEachAsync overloads for enumerable, async-enumerable, item, and execution-count builders. Adapt each delegate once to the builder's linked processor token so CancelAll, disposal, and external cancellation interrupt in-flight work without changing tokenless paths.
External cancellation can end source enumeration before started selectors finish. Keep unbounded action and result execution alive through selector cleanup. Refs #336
thomhurst
force-pushed
the
issue-336-cancellation-aware-selectors
branch
from
July 21, 2026 19:31
3ca0ada to
03785b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CancellationToken-awareSelectAsyncandForEachAsyncoverloads for enumerable, async-enumerable, item, and execution-count buildersCancelAll,DisposeAsync, and external cancellationValidation
Closes #336