refactor!: remove result-discarding InParallelAsync overloads and polish packaging#373
Merged
Conversation
…ish packaging The Func<TSource, Task<TResult>> and Func<TSource, TResult> overloads returned plain Task and silently dropped every result. Callers that want results already have SelectAsync(...).ProcessInParallel(...); result-returning delegates still bind to the surviving Func<TSource, Task> and Action<TSource> overloads with identical behaviour. Also: XML docs for ParallelExtensions and IAsyncProcessor, NuGet package icon, refreshed package description covering IAsyncEnumerable streaming and timed rate limiting.
Greptile SummaryThis PR prepares the public API and package for the v4 release. The main changes are:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "docs: correct InParallelAsync migration ..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Async value-returning lambdas and explicitly typed result delegates do not bind to the surviving overloads, and item faults take precedence over cancellation on the returned task.
Owner
Author
|
Both review comments addressed:
|
thomhurst
enabled auto-merge (squash)
July 22, 2026 00:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pre-4.0 API/packaging polish from the final release review:
InParallelAsyncoverloads (Func<TSource, Task<TResult>>x2 andFunc<TSource, TResult>). They returned a plainTaskand silently discarded every result. Results belong toSelectAsync(...).ProcessInParallel(...); existing calls passing result-returning delegates still compile against the survivingFunc<TSource, Task>/Action<TSource>overloads with identical behaviour.PublicAPI.Shipped.txttrimmed to match (v4 surface is unreleased) and a migration bullet added to the README.ParallelExtensionsmembers and a rewrite of the non-genericIAsyncProcessordocs from legacy/** */blocks to///style matchingIAsyncProcessor<TOutput>.icon.png, packed viaPackageIcon).IAsyncEnumerablestreaming, timed rate limiting, and the fluent API.Test plan
dotnet buildclean (0 errors; RS0016/RS0017 public-API analyzers stay as errors)dotnet test— 1716/1716 pass on net8.0, net9.0, net10.0dotnet pack -c Releasesucceeds; verifiedicon.pngandREADME.mdland in the nupkg root