refactor: Extract NuGet upload logic to shared helper (#1465)

* chore: Add .worktrees/ to .gitignore for parallel development

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: Extract NuGet upload logic to shared helper

Extract duplicated NuGet package upload logic from UploadPackagesToNugetModule
and UploadPackagesToLocalNuGetModule into a new NugetUploadHelper class.

Fixes #1459

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: Address code review feedback - type mismatch and null check

- Fix UploadPackagesToLocalNuGetModule.cs: Use .Path property on Folder
  object when passing to source parameter (fixes type mismatch)
- UploadPackagesToNugetModule.cs already has the required null check for
  API key at line 39

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines.Build/Helpers/NugetUploadHelper.cs

@@ -0,0 +1,28 @@
+using EnumerableAsyncProcessor.Extensions;
+using ModularPipelines.Context;
+using ModularPipelines.DotNet.Extensions;
+using ModularPipelines.DotNet.Options;
+using ModularPipelines.Models;
+using File = ModularPipelines.FileSystem.File;
+
+namespace ModularPipelines.Build.Helpers;
+
+public static class NugetUploadHelper
+{
+    public static async Task<CommandResult[]> UploadPackagesAsync(
+        IModuleContext context,
+        IEnumerable<File> packagePaths,
+        string source,
+        string? apiKey,
+        CancellationToken cancellationToken)
+    {
+        return await packagePaths
+            .SelectAsync(async nugetFile => await context.DotNet().Nuget.Push(new DotNetNugetPushOptions
+            {
+                Path = nugetFile,
+                Source = source,
+                ApiKey = apiKey,
+            }, cancellationToken), cancellationToken: cancellationToken)
+            .ProcessOneAtATime();
+    }
+}

src/ModularPipelines.Build/Modules/LocalMachine/UploadPackagesToLocalNuGetModule.cs

@@ -1,9 +1,6 @@
-using EnumerableAsyncProcessor.Extensions;
-using Microsoft.Extensions.Logging;
 using ModularPipelines.Attributes;
+using ModularPipelines.Build.Helpers;
 using ModularPipelines.Context;
-using ModularPipelines.DotNet.Extensions;
-using ModularPipelines.DotNet.Options;
 using ModularPipelines.Extensions;
 using ModularPipelines.FileSystem;
 using ModularPipelines.Models;
@@ -23,12 +20,11 @@ public class UploadPackagesToLocalNuGetModule : Module<CommandResult[]>
         var localRepoLocation = context.GetModule<CreateLocalNugetFolderModule, Folder>();
         var packagePaths = context.GetModule<PackagePathsParserModule, List<File>>();
 
-        return await packagePaths.Value!
-            .SelectAsync(async nugetFile => await context.DotNet().Nuget.Push(new DotNetNugetPushOptions
-            {
-                Path = nugetFile,
-                Source = localRepoLocation.Value.AssertExists(),
-            }, cancellationToken), cancellationToken: cancellationToken)
-            .ProcessOneAtATime();
+        return await NugetUploadHelper.UploadPackagesAsync(
+            context,
+            packagePaths.Value!,
+            source: localRepoLocation.Value.AssertExists()!.Path,
+            apiKey: null,
+            cancellationToken);
     }
 }

src/ModularPipelines.Build/Modules/UploadPackagesToNugetModule.cs

@@ -1,11 +1,8 @@
-using EnumerableAsyncProcessor.Extensions;
-using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
 using ModularPipelines.Attributes;
+using ModularPipelines.Build.Helpers;
 using ModularPipelines.Build.Settings;
 using ModularPipelines.Context;
-using ModularPipelines.DotNet.Extensions;
-using ModularPipelines.DotNet.Options;
 using ModularPipelines.Git.Attributes;
 using ModularPipelines.GitHub.Attributes;
 using ModularPipelines.Models;
@@ -43,13 +40,11 @@ public Task<SkipDecision> ShouldSkip(IPipelineContext context)
 
         var packagePaths = context.GetModule<PackagePathsParserModule, List<File>>();
 
-        return await packagePaths.Value!
-            .SelectAsync(async nugetFile => await context.DotNet().Nuget.Push(new DotNetNugetPushOptions
-            {
-                Path = nugetFile,
-                Source = "https://api.nuget.org/v3/index.json",
-                ApiKey = _nugetSettings.Value.ApiKey!,
-            }, cancellationToken), cancellationToken: cancellationToken)
-            .ProcessOneAtATime();
+        return await NugetUploadHelper.UploadPackagesAsync(
+            context,
+            packagePaths.Value!,
+            source: "https://api.nuget.org/v3/index.json",
+            apiKey: _nugetSettings.Value.ApiKey,
+            cancellationToken);
     }
 }