feat: Add Phase 2 Activity-based logging to FileSystem operations (#1694)

* feat: Enhance Folder.Clean() and CopyTo() methods with additional options

- Add Clean(bool removeReadOnlyAttribute) overload that:
  - Handles read-only files/directories by removing the attribute before deletion
  - Adds try-catch with logging for resilience when individual items fail
  - Includes private helper RemoveReadOnlyAttributeRecursively(DirectoryInfo)
  - Default Clean() calls Clean(removeReadOnlyAttribute: true)

- Add CopyTo(string targetPath, bool preserveTimestamps) overload that:
  - Preserves file and directory attributes
  - Optionally preserves CreationTimeUtc, LastWriteTimeUtc, LastAccessTimeUtc
  - Preserves root directory timestamps after all content is copied
  - Default CopyTo(targetPath) calls CopyTo(targetPath, preserveTimestamps: true)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* fix: Address PR review feedback for Folder enhancements

- Fix RemoveReadOnlyAttributeRecursively to use TopDirectoryOnly with recursion
  instead of AllDirectories (performance improvement)
- Change CopyTo log message to past tense "Copied Folder" (logging consistency)
- Remove try-catch from Clean() to preserve exception-throwing behavior
  (backward compatibility)
- Change CopyTo() default to preserveTimestamps: false (backward compatibility)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* feat: Add Phase 2 Activity-based logging to FileSystem operations

- Add GetCurrentModuleName() and GetCurrentActivityId() helper methods to
  ModuleActivityTracing for retrieving activity context
- Update File.cs logging methods to include module name and activity ID
  in all file operations (read, write, copy, move, delete, create, append)
- Update Folder.cs logging methods to include module name and activity ID
  in all folder operations (create, delete, clean, copy, move, get, search)
- Add private helper methods LogFileOperation, LogFileOperationWithDestination,
  LogFolderOperation, LogFolderOperationWithDestination, LogFolderOperationWithExpression,
  and LogFolderWarning for consistent activity context logging

This is Phase 2 of the Activity-based refactor, which uses Activity.Current
for context alongside the existing AsyncLocal pattern for backward compatibility.
The log messages now include the current module name and activity ID when available.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines/FileSystem/File.cs

@@ -1,7 +1,9 @@
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json.Serialization;
 using Microsoft.Extensions.Logging;
 using ModularPipelines.Logging;
+using ModularPipelines.Tracing;
 
 namespace ModularPipelines.FileSystem;
 
@@ -35,22 +37,22 @@ internal File(FileInfo fileInfo)
     /// <inheritdoc cref="System.IO.File.ReadAllTextAsync(string,System.Text.Encoding,System.Threading.CancellationToken)"/>>
     public Task<string> ReadAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadAllTextAsync(Path, cancellationToken);
     }
 
     /// <inheritdoc cref="System.IO.File.ReadLinesAsync(string,System.Threading.CancellationToken)"/>
     public IAsyncEnumerable<string> ReadLinesAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadLinesAsync(Path, cancellationToken);
     }
 
     public Task<byte[]> ReadBytesAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadAllBytesAsync(Path, cancellationToken);
     }
@@ -62,28 +64,28 @@ public FileStream GetStream(FileAccess fileAccess = FileAccess.ReadWrite)
 
     public Task WriteAsync(string contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllTextAsync(Path, contents, cancellationToken);
     }
 
     public Task WriteAsync(byte[] contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllBytesAsync(Path, contents, cancellationToken);
     }
 
     public Task WriteAsync(IEnumerable<string> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllLinesAsync(Path, contents, cancellationToken);
     }
 
     public async Task WriteAsync(ReadOnlyMemory<byte> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         await using (fileStream.ConfigureAwait(false))
@@ -94,7 +96,7 @@ public async Task WriteAsync(ReadOnlyMemory<byte> contents, CancellationToken ca
 
     public async Task WriteAsync(Stream contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         await using (fileStream.ConfigureAwait(false))
@@ -110,14 +112,14 @@ public async Task WriteAsync(Stream contents, CancellationToken cancellationToke
 
     public Task AppendAsync(string contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Appending to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.AppendAllTextAsync(Path, contents, cancellationToken);
     }
 
     public Task AppendAsync(IEnumerable<string> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Appending to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.AppendAllLinesAsync(Path, contents, cancellationToken);
     }
@@ -143,7 +145,7 @@ public Task AppendAsync(IEnumerable<string> contents, CancellationToken cancella
 
     public File Create()
     {
-        ModuleLogger.Current.LogInformation("Creating File: {Path}", this);
+        LogFileOperation("Creating File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         fileStream.Dispose();
@@ -174,15 +176,15 @@ public FileAttributes Attributes
     /// <inheritdoc cref="FileInfo.Delete"/>>
     public void Delete()
     {
-        ModuleLogger.Current.LogInformation("Deleting File: {File}", this);
+        LogFileOperation("Deleting File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         FileInfo.Delete();
     }
 
     /// <inheritdoc cref="FileInfo.MoveTo(string)"/>>
     public File MoveTo(string path)
     {
-        ModuleLogger.Current.LogInformation("Moving File: {Source} > {Destination}", this, path);
+        LogFileOperationWithDestination("Moving File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, path);
 
         FileInfo.MoveTo(path);
         return this;
@@ -191,7 +193,7 @@ public File MoveTo(string path)
     /// <inheritdoc cref="FileInfo.MoveTo(string)"/>>
     public File MoveTo(Folder folder)
     {
-        ModuleLogger.Current.LogInformation("Moving File: {Source} > {Destination}", this, folder);
+        LogFileOperationWithDestination("Moving File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, folder);
 
         folder.Create();
         return MoveTo(System.IO.Path.Combine(folder.Path, Name));
@@ -200,14 +202,14 @@ public File MoveTo(Folder folder)
     /// <inheritdoc cref="FileInfo.CopyTo(string)"/>>
     public File CopyTo(string path)
     {
-        ModuleLogger.Current.LogInformation("Copying File: {Source} > {Destination}", this, path);
+        LogFileOperationWithDestination("Copying File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, path);
 
         return FileInfo.CopyTo(path);
     }
 
     public File CopyTo(Folder folder)
     {
-        ModuleLogger.Current.LogInformation("Copying File: {Source} > {Destination}", this, folder);
+        LogFileOperationWithDestination("Copying File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, folder);
 
         folder.Create();
         return CopyTo(System.IO.Path.Combine(folder.Path, Name));
@@ -217,7 +219,7 @@ public static File GetNewTemporaryFilePath()
     {
         var path = System.IO.Path.Combine(System.IO.Path.GetTempPath(), System.IO.Path.GetRandomFileName());
 
-        ModuleLogger.Current.LogInformation("Temporary File Path: {Path}", path);
+        LogFileOperation("Temporary File Path: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", path);
 
         return path!;
     }
@@ -301,4 +303,30 @@ public override int GetHashCode()
     {
         return !Equals(left, right);
     }
-}
+
+    /// <summary>
+    /// Logs a file operation with Activity context information.
+    /// </summary>
+    /// <remarks>
+    /// Phase 2: Uses Activity.Current for context alongside AsyncLocal for backward compatibility.
+    /// The log message includes the current module name and activity ID when available.
+    /// </remarks>
+    private static void LogFileOperation(string messageTemplate, object? arg1)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, arg1, moduleName, activityId);
+    }
+
+    /// <summary>
+    /// Logs a file operation with Activity context information for operations with source and destination.
+    /// </summary>
+    private static void LogFileOperationWithDestination(string messageTemplate, object? source, object? destination)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, source, destination, moduleName, activityId);
+    }
+}