refactor: Replace magic numbers with named constants (#1470)

* chore: Add .worktrees/ to .gitignore for parallel development

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: Replace magic numbers with named constants

- Create LoggingConstants with SecretMask, CommandMask, and body size constants
- Create ConcurrencyConstants with ParallelismMultiplier
- Add TestFramework constant to BuildConstants
- Update SecretObfuscator to use LoggingConstants.SecretMask
- Update CommandLogger to use LoggingConstants.CommandMask
- Update HttpLoggingOptions to use LoggingConstants for body size limits
- Update ConcurrencyOptions to use ConcurrencyConstants.ParallelismMultiplier
- Update RunUnitTestsModule to use BuildConstants.TestFramework

Fixes #1457

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines.Build/BuildConstants.cs

@@ -1,7 +1,15 @@
 namespace ModularPipelines.Build;
 
+/// <summary>
+/// Constants used for build configuration.
+/// </summary>
 public static class BuildConstants
 {
     public const string Owner = "thomhurst";
     public const string RepositoryName = "ModularPipelines";
+
+    /// <summary>
+    /// The target framework for running tests.
+    /// </summary>
+    public const string TestFramework = "net10.0";
 }

src/ModularPipelines.Build/Modules/RunUnitTestsModule.cs

@@ -30,7 +30,7 @@ public class RunUnitTestsModule : Module<CommandResult[]>, IRetryable<CommandRes
             {
                 Project = unitTestProjectFile.Path,
                 NoBuild = true,
-                Framework = "net10.0",
+                Framework = BuildConstants.TestFramework,
                 Arguments = ["--coverage", "--coverage-output-format", "cobertura"],
                 Configuration = Configuration.Release,
                 EnvironmentVariables = new Dictionary<string, string?>

src/ModularPipelines/Constants/ConcurrencyConstants.cs

@@ -0,0 +1,12 @@
+namespace ModularPipelines.Constants;
+
+/// <summary>
+/// Constants used for concurrency and parallelism configuration.
+/// </summary>
+internal static class ConcurrencyConstants
+{
+    /// <summary>
+    /// The multiplier applied to ProcessorCount to calculate default maximum parallelism.
+    /// </summary>
+    public const int ParallelismMultiplier = 4;
+}

src/ModularPipelines/Constants/LoggingConstants.cs

@@ -0,0 +1,27 @@
+namespace ModularPipelines.Constants;
+
+/// <summary>
+/// Constants used for logging and output formatting.
+/// </summary>
+internal static class LoggingConstants
+{
+    /// <summary>
+    /// The string used to mask secret values in logs.
+    /// </summary>
+    public const string SecretMask = "**********";
+
+    /// <summary>
+    /// The string used to mask command arguments when they should not be displayed.
+    /// </summary>
+    public const string CommandMask = "********";
+
+    /// <summary>
+    /// Default maximum body size (4KB) for HTTP logging.
+    /// </summary>
+    public const int DefaultMaxBodySizeToLog = 4096;
+
+    /// <summary>
+    /// Full logging maximum body size (64KB) for HTTP logging.
+    /// </summary>
+    public const int FullLoggingMaxBodySize = 65536;
+}

src/ModularPipelines/Engine/SecretObfuscator.cs

@@ -1,5 +1,6 @@
 using System.Text;
 using Initialization.Microsoft.Extensions.DependencyInjection;
+using ModularPipelines.Constants;
 
 namespace ModularPipelines.Engine;
 
@@ -30,7 +31,7 @@ public string Obfuscate(string? input, object? optionsObject)
         {
             if (input.Contains(secret))
             {
-                stringBuilder.Replace(secret, "**********");
+                stringBuilder.Replace(secret, LoggingConstants.SecretMask);
             }
         }
 

src/ModularPipelines/Logging/CommandLogger.cs

@@ -1,5 +1,6 @@
 using Microsoft.Extensions.Logging;
 using Microsoft.Extensions.Options;
+using ModularPipelines.Constants;
 using ModularPipelines.Engine;
 using ModularPipelines.Enums;
 using ModularPipelines.Helpers;
@@ -130,7 +131,7 @@ private void LogCommandInput(CommandLoggingOptions options, CommandLineToolOptio
         }
         else
         {
-            Logger.LogInformation("{Timestamp}Command: {WorkingDirectory}> ********",
+            Logger.LogInformation("{Timestamp}Command: {WorkingDirectory}> " + LoggingConstants.CommandMask,
                 timestamp,
                 workingDirectory);
         }

src/ModularPipelines/Options/ConcurrencyOptions.cs

@@ -1,4 +1,5 @@
 using System.Diagnostics.CodeAnalysis;
+using ModularPipelines.Constants;
 
 namespace ModularPipelines.Options;
 
@@ -22,7 +23,7 @@ public record ConcurrencyOptions
     /// options.Concurrency.MaxParallelism = int.MaxValue;
     /// </code>
     /// </example>
-    public int MaxParallelism { get; set; } = Environment.ProcessorCount * 4;
+    public int MaxParallelism { get; set; } = Environment.ProcessorCount * ConcurrencyConstants.ParallelismMultiplier;
 
     /// <summary>
     /// Gets or sets the maximum number of CPU-intensive modules that can execute concurrently.

src/ModularPipelines/Options/HttpLoggingOptions.cs

@@ -1,3 +1,5 @@
+using ModularPipelines.Constants;
+
 namespace ModularPipelines.Options;
 
 /// <summary>
@@ -67,7 +69,7 @@ public record HttpLoggingOptions
     /// Bodies larger than this will be truncated with a message indicating the full size.
     /// Set to 0 or negative to disable truncation.
     /// </summary>
-    public int MaxBodySizeToLog { get; init; } = 4096;
+    public int MaxBodySizeToLog { get; init; } = LoggingConstants.DefaultMaxBodySizeToLog;
 
     /// <summary>
     /// Default logging options (all logging enabled, 4KB body limit).
@@ -132,6 +134,6 @@ public record HttpLoggingOptions
         LogResponseBody = true,
         LogStatusCode = true,
         LogDuration = true,
-        MaxBodySizeToLog = 65536,
+        MaxBodySizeToLog = LoggingConstants.FullLoggingMaxBodySize,
     };
 }