Skip to content

Commit 1ea1e46

Browse files
thomhurstclaude
andcommitted
fix: Dispose FileStream properly and use OfType<string>
- Fix resource leak by wrapping FileStream in await using statement - Use .OfType<string>() instead of .Where(v => v != null) for better null handling and type safety 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent a5511f5 commit 1ea1e46

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

src/ModularPipelines.Build/Modules/FindProjectDependenciesModule.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,15 +18,16 @@ public class FindProjectDependenciesModule : Module<FindProjectDependenciesModul
1818

1919
foreach (var file in projects.Value!)
2020
{
21+
await using var stream = System.IO.File.OpenRead(file.Path);
2122
var doc = await XDocument.LoadAsync(
22-
System.IO.File.OpenRead(file.Path),
23+
stream,
2324
LoadOptions.None,
2425
cancellationToken);
2526

2627
var projectReferences = doc.Descendants()
2728
.Where(e => e.Name.LocalName == "ProjectReference")
2829
.Select(e => e.Attribute("Include")?.Value)
29-
.Where(v => v != null);
30+
.OfType<string>();
3031

3132
foreach (var reference in projectReferences)
3233
{

0 commit comments

Comments
 (0)