fix: Remove unnecessary finalizer from ModuleOutputWriter (#1533) (#1727)

- Remove finalizer since class only manages managed resources
- Fix bug where _scope was not disposed when buffer had no events
- Remove GC.SuppressFinalize since no finalizer exists
- Add documentation explaining why finalizer is not needed

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines/Logging/ModuleOutputWriter.cs

@@ -119,6 +119,10 @@ internal void SetException(Exception exception)
     /// <summary>
     /// Flushes all buffered output with section header/footer.
     /// </summary>
+    /// <remarks>
+    /// No finalizer is needed since this class only manages managed resources.
+    /// If Dispose is not called, the IServiceScope will be cleaned up by GC.
+    /// </remarks>
     public void Dispose()
     {
         lock (_writeLock)
@@ -133,6 +137,7 @@ public void Dispose()
 
         if (!_buffer.HasEvents)
         {
+            _scope.Dispose();
             return;
         }
 
@@ -173,12 +178,6 @@ public void Dispose()
         }
 
         _scope.Dispose();
-        GC.SuppressFinalize(this);
-    }
-
-    ~ModuleOutputWriter()
-    {
-        Dispose();
     }
 
     /// <summary>