feat: Add Phase 2 Activity-based logging to FileSystem operations

- Add GetCurrentModuleName() and GetCurrentActivityId() helper methods to
  ModuleActivityTracing for retrieving activity context
- Update File.cs logging methods to include module name and activity ID
  in all file operations (read, write, copy, move, delete, create, append)
- Update Folder.cs logging methods to include module name and activity ID
  in all folder operations (create, delete, clean, copy, move, get, search)
- Add private helper methods LogFileOperation, LogFileOperationWithDestination,
  LogFolderOperation, LogFolderOperationWithDestination, LogFolderOperationWithExpression,
  and LogFolderWarning for consistent activity context logging

This is Phase 2 of the Activity-based refactor, which uses Activity.Current
for context alongside the existing AsyncLocal pattern for backward compatibility.
The log messages now include the current module name and activity ID when available.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines/FileSystem/File.cs

@@ -1,7 +1,9 @@
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Text.Json.Serialization;
 using Microsoft.Extensions.Logging;
 using ModularPipelines.Logging;
+using ModularPipelines.Tracing;
 
 namespace ModularPipelines.FileSystem;
 
@@ -35,22 +37,22 @@ internal File(FileInfo fileInfo)
     /// <inheritdoc cref="System.IO.File.ReadAllTextAsync(string,System.Text.Encoding,System.Threading.CancellationToken)"/>>
     public Task<string> ReadAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadAllTextAsync(Path, cancellationToken);
     }
 
     /// <inheritdoc cref="System.IO.File.ReadLinesAsync(string,System.Threading.CancellationToken)"/>
     public IAsyncEnumerable<string> ReadLinesAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadLinesAsync(Path, cancellationToken);
     }
 
     public Task<byte[]> ReadBytesAsync(CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Reading File: {Path}", this);
+        LogFileOperation("Reading File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.ReadAllBytesAsync(Path, cancellationToken);
     }
@@ -62,28 +64,28 @@ public FileStream GetStream(FileAccess fileAccess = FileAccess.ReadWrite)
 
     public Task WriteAsync(string contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllTextAsync(Path, contents, cancellationToken);
     }
 
     public Task WriteAsync(byte[] contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllBytesAsync(Path, contents, cancellationToken);
     }
 
     public Task WriteAsync(IEnumerable<string> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.WriteAllLinesAsync(Path, contents, cancellationToken);
     }
 
     public async Task WriteAsync(ReadOnlyMemory<byte> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         await using (fileStream.ConfigureAwait(false))
@@ -94,7 +96,7 @@ public async Task WriteAsync(ReadOnlyMemory<byte> contents, CancellationToken ca
 
     public async Task WriteAsync(Stream contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Writing to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         await using (fileStream.ConfigureAwait(false))
@@ -110,14 +112,14 @@ public async Task WriteAsync(Stream contents, CancellationToken cancellationToke
 
     public Task AppendAsync(string contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Appending to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.AppendAllTextAsync(Path, contents, cancellationToken);
     }
 
     public Task AppendAsync(IEnumerable<string> contents, CancellationToken cancellationToken = default)
     {
-        ModuleLogger.Current.LogInformation("Writing to File: {Path}", this);
+        LogFileOperation("Appending to File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         return System.IO.File.AppendAllLinesAsync(Path, contents, cancellationToken);
     }
@@ -143,7 +145,7 @@ public Task AppendAsync(IEnumerable<string> contents, CancellationToken cancella
 
     public File Create()
     {
-        ModuleLogger.Current.LogInformation("Creating File: {Path}", this);
+        LogFileOperation("Creating File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         var fileStream = System.IO.File.Create(Path);
         fileStream.Dispose();
@@ -174,15 +176,15 @@ public FileAttributes Attributes
     /// <inheritdoc cref="FileInfo.Delete"/>>
     public void Delete()
     {
-        ModuleLogger.Current.LogInformation("Deleting File: {File}", this);
+        LogFileOperation("Deleting File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         FileInfo.Delete();
     }
 
     /// <inheritdoc cref="FileInfo.MoveTo(string)"/>>
     public File MoveTo(string path)
     {
-        ModuleLogger.Current.LogInformation("Moving File: {Source} > {Destination}", this, path);
+        LogFileOperationWithDestination("Moving File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, path);
 
         FileInfo.MoveTo(path);
         return this;
@@ -191,7 +193,7 @@ public File MoveTo(string path)
     /// <inheritdoc cref="FileInfo.MoveTo(string)"/>>
     public File MoveTo(Folder folder)
     {
-        ModuleLogger.Current.LogInformation("Moving File: {Source} > {Destination}", this, folder);
+        LogFileOperationWithDestination("Moving File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, folder);
 
         folder.Create();
         return MoveTo(System.IO.Path.Combine(folder.Path, Name));
@@ -200,14 +202,14 @@ public File MoveTo(Folder folder)
     /// <inheritdoc cref="FileInfo.CopyTo(string)"/>>
     public File CopyTo(string path)
     {
-        ModuleLogger.Current.LogInformation("Copying File: {Source} > {Destination}", this, path);
+        LogFileOperationWithDestination("Copying File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, path);
 
         return FileInfo.CopyTo(path);
     }
 
     public File CopyTo(Folder folder)
     {
-        ModuleLogger.Current.LogInformation("Copying File: {Source} > {Destination}", this, folder);
+        LogFileOperationWithDestination("Copying File: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, folder);
 
         folder.Create();
         return CopyTo(System.IO.Path.Combine(folder.Path, Name));
@@ -217,7 +219,7 @@ public static File GetNewTemporaryFilePath()
     {
         var path = System.IO.Path.Combine(System.IO.Path.GetTempPath(), System.IO.Path.GetRandomFileName());
 
-        ModuleLogger.Current.LogInformation("Temporary File Path: {Path}", path);
+        LogFileOperation("Temporary File Path: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", path);
 
         return path!;
     }
@@ -301,4 +303,30 @@ public override int GetHashCode()
     {
         return !Equals(left, right);
     }
-}
+
+    /// <summary>
+    /// Logs a file operation with Activity context information.
+    /// </summary>
+    /// <remarks>
+    /// Phase 2: Uses Activity.Current for context alongside AsyncLocal for backward compatibility.
+    /// The log message includes the current module name and activity ID when available.
+    /// </remarks>
+    private static void LogFileOperation(string messageTemplate, object? arg1)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, arg1, moduleName, activityId);
+    }
+
+    /// <summary>
+    /// Logs a file operation with Activity context information for operations with source and destination.
+    /// </summary>
+    private static void LogFileOperationWithDestination(string messageTemplate, object? source, object? destination)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, source, destination, moduleName, activityId);
+    }
+}

src/ModularPipelines/FileSystem/Folder.cs

@@ -1,3 +1,4 @@
+using System.Diagnostics;
 using System.Diagnostics.CodeAnalysis;
 using System.Runtime.CompilerServices;
 using System.Text.Json.Serialization;
@@ -6,6 +7,7 @@
 using Microsoft.Extensions.Logging;
 using ModularPipelines.JsonUtils;
 using ModularPipelines.Logging;
+using ModularPipelines.Tracing;
 
 namespace ModularPipelines.FileSystem;
 
@@ -77,15 +79,15 @@ public Folder Root
 
     public Folder Create()
     {
-        ModuleLogger.Current.LogInformation("Creating Folder: {Path}", this);
+        LogFolderOperation("Creating Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         Directory.CreateDirectory(Path);
         return this;
     }
 
     public void Delete()
     {
-        ModuleLogger.Current.LogInformation("Deleting Folder: {Path}", this);
+        LogFolderOperation("Deleting Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         DirectoryInfo.Delete(true);
     }
@@ -107,7 +109,7 @@ public void Clean()
     /// </param>
     public void Clean(bool removeReadOnlyAttribute)
     {
-        ModuleLogger.Current.LogInformation("Cleaning Folder: {Path}", this);
+        LogFolderOperation("Cleaning Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", this);
 
         foreach (var directory in DirectoryInfo.EnumerateDirectories("*", SearchOption.TopDirectoryOnly))
         {
@@ -204,14 +206,14 @@ public Folder CopyTo(string targetPath, bool preserveTimestamps)
             targetRootDir.LastAccessTimeUtc = DirectoryInfo.LastAccessTimeUtc;
         }
 
-        ModuleLogger.Current.LogInformation("Copied Folder: {Source} > {Destination}", this, targetPath);
+        LogFolderOperationWithDestination("Copied Folder: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, targetPath);
 
         return new Folder(targetPath);
     }
 
     public Folder MoveTo(string path)
     {
-        ModuleLogger.Current.LogInformation("Moving Folder: {Source} > {Destination}", this, path);
+        LogFolderOperationWithDestination("Moving Folder: {Source} > {Destination} [Module: {ModuleName}, Activity: {ActivityId}]", this, path);
 
         DirectoryInfo.MoveTo(path);
         return this;
@@ -221,7 +223,7 @@ public Folder GetFolder(string name)
     {
         var directoryInfo = new DirectoryInfo(System.IO.Path.Combine(Path, name));
 
-        ModuleLogger.Current.LogInformation("Getting Folder: {Path}", directoryInfo.FullName);
+        LogFolderOperation("Getting Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", directoryInfo.FullName);
 
         return directoryInfo;
     }
@@ -230,7 +232,7 @@ public Folder CreateFolder(string name)
     {
         var folder = GetFolder(name).Create();
 
-        ModuleLogger.Current.LogInformation("Creating Folder: {Path}", folder);
+        LogFolderOperation("Creating Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", folder);
 
         return folder;
     }
@@ -239,7 +241,7 @@ public File GetFile(string name)
     {
         var fileInfo = new FileInfo(System.IO.Path.Combine(Path, name));
 
-        ModuleLogger.Current.LogInformation("Getting File: {Path}", fileInfo.FullName);
+        LogFolderOperation("Getting File: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", fileInfo.FullName);
 
         return fileInfo;
     }
@@ -255,7 +257,7 @@ public File CreateFile(string name)
 
     public IEnumerable<Folder> GetFolders(Func<Folder, bool> predicate, Func<Folder, bool> exclusionFilters, [CallerArgumentExpression("predicate")] string predicateExpression = "")
     {
-        ModuleLogger.Current.LogInformation("Searching Folders in: {Path} > {Expression}", this, predicateExpression);
+        LogFolderOperationWithExpression("Searching Folders in: {Path} > {Expression} [Module: {ModuleName}, Activity: {ActivityId}]", this, predicateExpression);
 
         return SafeWalk.EnumerateFolders(this, exclusionFilters)
             .Select(x => new Folder(x))
@@ -265,7 +267,7 @@ public IEnumerable<Folder> GetFolders(Func<Folder, bool> predicate, Func<Folder,
 
     public IEnumerable<File> GetFiles(Func<File, bool> predicate, Func<Folder, bool> directoryExclusionFilters, [CallerArgumentExpression("predicate")] string predicateExpression = "")
     {
-        ModuleLogger.Current.LogInformation("Searching Files in: {Path} > {Expression}", this, predicateExpression);
+        LogFolderOperationWithExpression("Searching Files in: {Path} > {Expression} [Module: {ModuleName}, Activity: {ActivityId}]", this, predicateExpression);
 
         return SafeWalk.EnumerateFiles(this, directoryExclusionFilters)
             .Select(x => new File(x))
@@ -275,7 +277,7 @@ public IEnumerable<File> GetFiles(Func<File, bool> predicate, Func<Folder, bool>
 
     public IEnumerable<File> GetFiles(string globPattern)
     {
-        ModuleLogger.Current.LogInformation("Searching Files in: {Path} > {Glob}", this, globPattern);
+        LogFolderOperationWithExpression("Searching Files in: {Path} > {Glob} [Module: {ModuleName}, Activity: {ActivityId}]", this, globPattern);
 
         return new Matcher(StringComparison.OrdinalIgnoreCase)
             .AddInclude(globPattern)
@@ -312,7 +314,7 @@ public static Folder CreateTemporaryFolder()
         var tempDirectory = System.IO.Path.Combine(System.IO.Path.GetTempPath(), System.IO.Path.GetRandomFileName().Replace(".", string.Empty));
         Directory.CreateDirectory(tempDirectory);
 
-        ModuleLogger.Current.LogInformation("Creating Temporary Folder: {Path}", tempDirectory);
+        LogFolderOperation("Creating Temporary Folder: {Path} [Module: {ModuleName}, Activity: {ActivityId}]", tempDirectory);
 
         return tempDirectory!;
     }
@@ -417,4 +419,52 @@ private static void RemoveReadOnlyAttributeRecursively(DirectoryInfo directory)
             RemoveReadOnlyAttributeRecursively(subDirectory);
         }
     }
-}
+
+    /// <summary>
+    /// Logs a folder operation with Activity context information.
+    /// </summary>
+    /// <remarks>
+    /// Phase 2: Uses Activity.Current for context alongside AsyncLocal for backward compatibility.
+    /// The log message includes the current module name and activity ID when available.
+    /// </remarks>
+    private static void LogFolderOperation(string messageTemplate, object? arg1)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, arg1, moduleName, activityId);
+    }
+
+    /// <summary>
+    /// Logs a folder operation with Activity context information for operations with source and destination.
+    /// </summary>
+    private static void LogFolderOperationWithDestination(string messageTemplate, object? source, object? destination)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, source, destination, moduleName, activityId);
+    }
+
+    /// <summary>
+    /// Logs a folder operation with Activity context information for operations with path and expression/glob.
+    /// </summary>
+    private static void LogFolderOperationWithExpression(string messageTemplate, object? path, object? expression)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogInformation(messageTemplate, path, expression, moduleName, activityId);
+    }
+
+    /// <summary>
+    /// Logs a folder warning with Activity context information.
+    /// </summary>
+    private static void LogFolderWarning(Exception ex, string messageTemplate, object? arg1)
+    {
+        var moduleName = ModuleActivityTracing.GetCurrentModuleName() ?? "Unknown";
+        var activityId = ModuleActivityTracing.GetCurrentActivityId();
+
+        ModuleLogger.Current.LogWarning(ex, messageTemplate, arg1, moduleName, activityId);
+    }
+}

src/ModularPipelines/Tracing/ModuleActivityTracing.cs

@@ -109,4 +109,22 @@ public static void RecordFailure(Activity? activity, Exception exception)
         activity.SetTag(ExceptionMessageTag, exception.Message);
         activity.SetStatus(ActivityStatusCode.Error, exception.Message);
     }
+
+    /// <summary>
+    /// Gets the current module name from the current Activity, if available.
+    /// </summary>
+    /// <returns>The module name, or null if no module activity is active.</returns>
+    public static string? GetCurrentModuleName()
+    {
+        return Activity.Current?.GetTagItem(ModuleTypeTag) as string;
+    }
+
+    /// <summary>
+    /// Gets the current Activity ID, if available.
+    /// </summary>
+    /// <returns>The activity ID, or null if no activity is active.</returns>
+    public static string? GetCurrentActivityId()
+    {
+        return Activity.Current?.Id;
+    }
 }