Skip to content

Commit 8f5361e

Browse files
thomhurstclaude
andcommitted
fix: remove Arguments property deprecation analyzer (MP0010)
The Arguments property provides important flexibility for users to customize commands when the typed options class doesn't cover a specific CLI flag or when new CLI features are added before the model is updated. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
1 parent 0a2d8d0 commit 8f5361e

File tree

3 files changed

+0
-117
lines changed

3 files changed

+0
-117
lines changed

src/ModularPipelines.Analyzers/ModularPipelines.Analyzers/AnalyzerReleases.Unshipped.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@ Rule ID | Category | Severity | Notes
44
--------|----------|----------|--------------------
55
AwaitThis | Usage | Error | Prohibit await this in modules
66
StatefulModule | Design | Warning | Detects mutable instance fields in modules that could leak state between executions
7-
MP0010 | Migration | Warning | Warns when deprecated Arguments property is used on CommandLineToolOptions
87
MPDEP001 | Usage | Error | DependsOn type does not implement IModule
98
MPDEP002 | Usage | Error | Circular dependency detected between modules (renamed from ConflictingDependsOnAttribute)
109
MPDEP003 | Usage | Error | Module depends on itself

src/ModularPipelines.Analyzers/ModularPipelines.Analyzers/ArgumentsPropertyDeprecatedAnalyzer.cs

Lines changed: 0 additions & 107 deletions
This file was deleted.

src/ModularPipelines.Analyzers/ModularPipelines.Analyzers/Resources.resx

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -189,15 +189,6 @@
189189
<data name="StatefulModuleAnalyzerDescription" xml:space="preserve">
190190
<value>Modules are registered as Singletons in the dependency injection container and can be executed multiple times (retries, sub-modules, parallel pipelines). Instance fields can leak state between executions. Use readonly fields for injected dependencies, or store execution state in IModuleContext.</value>
191191
</data>
192-
<data name="ArgumentsPropertyDeprecatedAnalyzerTitle" xml:space="preserve">
193-
<value>Arguments property is deprecated</value>
194-
</data>
195-
<data name="ArgumentsPropertyDeprecatedAnalyzerMessageFormat" xml:space="preserve">
196-
<value>The 'Arguments' property on '{0}' is deprecated. Use typed positional argument properties instead</value>
197-
</data>
198-
<data name="ArgumentsPropertyDeprecatedAnalyzerDescription" xml:space="preserve">
199-
<value>The Arguments property bypasses type safety. In ModularPipelines v2, use typed positional argument properties marked with [CliArgument] instead. For example, use 'Committish = "HEAD"' on GitRevParseOptions instead of 'Arguments = ["HEAD"]'. If no typed property exists, request one be added or use GenericCommandLineToolOptions.</value>
200-
</data>
201192
<data name="InvalidDependsOnTypeAnalyzerTitle" xml:space="preserve">
202193
<value>Invalid DependsOn type</value>
203194
</data>

0 commit comments

Comments
 (0)