Skip to content

Commit de34216

Browse files
committed
refactor: remove unused modules and dependencies from build pipeline
1 parent 33066cc commit de34216

7 files changed

Lines changed: 1 addition & 200 deletions

File tree

src/ModularPipelines.Build/Modules/ChangedFilesInPullRequestModule.cs

Lines changed: 0 additions & 28 deletions
This file was deleted.

src/ModularPipelines.Build/Modules/CodeFormattedNicelyModule.cs

Lines changed: 0 additions & 95 deletions
This file was deleted.

src/ModularPipelines.Build/Modules/CreateReleaseModule.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ namespace ModularPipelines.Build.Modules;
1818
[RunOnLinuxOnly]
1919
[DependsOn<NugetVersionGeneratorModule>]
2020
[DependsOn<UploadPackagesToNugetModule>]
21-
[DependsOn<DependabotCommitsModule>]
2221
public class CreateReleaseModule : Module<Release>
2322
{
2423
private readonly IOptions<GitHubSettings> _githubSettings;

src/ModularPipelines.Build/Modules/DependabotCommitsModule.cs

Lines changed: 0 additions & 39 deletions
This file was deleted.

src/ModularPipelines.Build/Modules/PackProjectsModule.cs

Lines changed: 1 addition & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
using EnumerableAsyncProcessor.Extensions;
2-
using Microsoft.Extensions.Logging;
32
using ModularPipelines.Attributes;
43
using ModularPipelines.Context;
54
using ModularPipelines.DotNet.Extensions;
@@ -13,9 +12,7 @@ namespace ModularPipelines.Build.Modules;
1312

1413
[DependsOn<NugetVersionGeneratorModule>]
1514
[DependsOn<PackageFilesRemovalModule>]
16-
[DependsOn<CodeFormattedNicelyModule>(IgnoreIfNotRegistered = true)]
1715
[DependsOn<FindProjectDependenciesModule>]
18-
[DependsOn<ChangedFilesInPullRequestModule>]
1916
[DependsOn<RunUnitTestsModule>]
2017
[RunOnLinuxOnly]
2118
public class PackProjectsModule : Module<CommandResult[]>
@@ -26,49 +23,20 @@ public class PackProjectsModule : Module<CommandResult[]>
2623

2724
var projectFiles = context.GetModule<FindProjectDependenciesModule, FindProjectDependenciesModule.ProjectDependencies>();
2825

29-
var changedFiles = context.GetModule<ChangedFilesInPullRequestModule, IReadOnlyList<File>>();
3026

3127
var dependencies = await projectFiles.ValueOrDefault!.Dependencies
3228
.ToAsyncProcessorBuilder()
3329
.SelectAsync(async projectFile => await Pack(context, cancellationToken, projectFile, packageVersion))
3430
.ProcessOneAtATime();
35-
36-
var gitVersioningInformation = await context.Git().Versioning.GetGitVersioningInformation();
37-
31+
3832
var others = await projectFiles.ValueOrDefault!.Others
39-
.Where(x =>
40-
{
41-
if (changedFiles.SkipDecisionOrDefault?.ShouldSkip == true)
42-
{
43-
return true;
44-
}
45-
46-
return ProjectHasChanged(x,
47-
changedFiles.ValueOrDefault!, context);
48-
})
4933
.ToAsyncProcessorBuilder()
5034
.SelectAsync(async projectFile => await Pack(context, cancellationToken, projectFile, packageVersion))
5135
.ProcessInParallel();
5236

5337
return dependencies.Concat(others).ToArray();
5438
}
5539

56-
private bool ProjectHasChanged(File projectFile, IEnumerable<File> changedFiles,
57-
IModuleContext context)
58-
{
59-
var projectDirectory = projectFile.Folder!;
60-
61-
if (!changedFiles.Any(x => x.Path.Contains(projectDirectory.Path)))
62-
{
63-
context.Logger.LogInformation("{Project} has not changed so not packing it", projectFile.Name);
64-
return false;
65-
}
66-
67-
context.Logger.LogInformation("{Project} has changed so packing it", projectFile.Name);
68-
69-
return true;
70-
}
71-
7240
private static async Task<CommandResult> Pack(IModuleContext context, CancellationToken cancellationToken, File projectFile, ModuleResult<string> packageVersion)
7341
{
7442
return await context.DotNet().Pack(new DotNetPackOptions

src/ModularPipelines.Build/Modules/RunUnitTestsModule.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@
1414

1515
namespace ModularPipelines.Build.Modules;
1616

17-
[DependsOn<CodeFormattedNicelyModule>(IgnoreIfNotRegistered = true)]
1817
public class RunUnitTestsModule : Module<CommandResult[]>
1918
{
2019
private readonly IOptions<PipelineSettings> _pipelineSettings;

src/ModularPipelines.Build/Program.cs

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,8 @@
3535
.AddModule<PackProjectsModule>()
3636
.AddModule<PackageFilesRemovalModule>()
3737
.AddModule<PackagePathsParserModule>()
38-
.AddModule<CodeFormattedNicelyModule>()
3938
.AddModule<GenerateReadMeModule>()
4039
.AddModule<FormatMarkdownModule>()
41-
.AddModule<ChangedFilesInPullRequestModule>()
42-
.AddModule<DependabotCommitsModule>()
4340
.AddModule<PrintEnvironmentVariablesModule>()
4441
.AddModule<PrintGitInformationModule>()
4542
.AddModule<PushVersionTagModule>()

0 commit comments

Comments
 (0)