refactor: Remove redundant code and extract magic numbers (#1659)

* refactor: Remove redundant case-sensitive string comparisons

Remove redundant Ordinal string comparisons that are already covered
by OrdinalIgnoreCase checks in ShouldSkipBasedOnHelpText method:
- helpText.Contains("deprecated", StringComparison.Ordinal)
- helpText.Contains("experimental", StringComparison.Ordinal)

Closes #1622

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* refactor: Extract magic number to named constant

Replace magic number 5000 with named constant ProgressPrinterGracePeriodMs
in PrintProgressExecutor.DisposeAsync to improve code readability
and maintainability.

Closes #1618

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>

Author: thomhurst

src/ModularPipelines/Engine/Executors/PrintProgressExecutor.cs

@@ -7,6 +7,11 @@ namespace ModularPipelines.Engine.Executors;
 [StackTraceHidden]
 internal class PrintProgressExecutor : IPrintProgressExecutor
 {
+    /// <summary>
+    /// Grace period in milliseconds for progress printer to complete before forced cancellation.
+    /// </summary>
+    private const int ProgressPrinterGracePeriodMs = 5000;
+
     private readonly EngineCancellationToken _engineCancellationToken;
     private readonly IConsolePrinter _consolePrinter;
     private readonly IModuleRetriever _moduleRetriever;
@@ -41,7 +46,7 @@ public async Task<IPrintProgressExecutor> InitializeAsync()
 
     public async ValueTask DisposeAsync()
     {
-        _printProgressCancellationTokenSource?.CancelAfter(5000);
+        _printProgressCancellationTokenSource?.CancelAfter(ProgressPrinterGracePeriodMs);
 
         await SafelyAwaitProgressPrinter().ConfigureAwait(false);
     }
@@ -60,4 +65,4 @@ private async Task SafelyAwaitProgressPrinter()
             _logger.LogWarning(e, "Error while waiting for progress to update");
         }
     }
-}
+}

tools/ModularPipelines.OptionsGenerator/src/ModularPipelines.OptionsGenerator/Scrapers/Cli/CliScraperBase.cs

@@ -448,8 +448,7 @@ protected virtual bool ShouldSkipBasedOnHelpText(string helpText)
         // Check for deprecated commands
         if (SkipDeprecatedCommands)
         {
-            if (helpText.Contains("DEPRECATED", StringComparison.OrdinalIgnoreCase) ||
-                helpText.Contains("deprecated", StringComparison.Ordinal))
+            if (helpText.Contains("DEPRECATED", StringComparison.OrdinalIgnoreCase))
             {
                 return true;
             }
@@ -460,7 +459,6 @@ protected virtual bool ShouldSkipBasedOnHelpText(string helpText)
         {
             if (helpText.Contains("EXPERIMENTAL", StringComparison.OrdinalIgnoreCase) ||
                 helpText.Contains("BETA", StringComparison.OrdinalIgnoreCase) ||
-                helpText.Contains("experimental", StringComparison.Ordinal) ||
                 helpText.Contains("(beta)", StringComparison.OrdinalIgnoreCase))
             {
                 return true;