refactor: Consolidate encoding/hashing tests to eliminate DRY violations

[thomhurst]

Summary

• Consolidates 7 separate encoding/hashing test files into a single EncodingTests.cs file
• Eliminates ~290 lines of duplicated test code while maintaining all 18 original test cases
• Uses organized regions to group related tests (Base64, Hex, Hash algorithms)
• Shared module definitions reduce repetitive boilerplate

Changes

Files Removed

• Base64Tests.cs (67 lines)
• HexTests.cs (67 lines)
• Md5Tests.cs (38 lines)
• Sha1Tests.cs (38 lines)
• Sha256Tests.cs (38 lines)
• Sha384Tests.cs (38 lines)
• Sha512Tests.cs (38 lines)

Files Added

• EncodingTests.cs - consolidated test class with all functionality preserved

Test Plan

• All 18 encoding/hashing tests pass
• Build succeeds without errors
• Test coverage maintained (same test cases as before)

Closes #1455

🤖 Generated with Claude Code

[github-actions]

Summary

Consolidates 7 separate encoding/hashing test files into a single EncodingTests.cs file, reducing ~290 lines of duplicated code while preserving all 18 test cases.

Critical Issues

None found ✅

Suggestions

Remove Unused Test Data Methods

The methods BidirectionalEncodingData() and HashData() at lines 22-60 are defined but never used. They appear to be remnants from an attempt at data-driven testing that wasn't completed. Consider removing them to keep the code clean.

Location: test/ModularPipelines.UnitTests/Helpers/EncodingTests.cs:22-60

Similarly, the EncodingModule class (lines 70-82) is unused and should be removed.

Rationale: The current approach uses concrete module classes (ToBase64Module, FromBase64Module, etc.) which works fine for this test suite. The data-driven infrastructure adds unnecessary complexity without providing value.

Verdict

✅ APPROVE - No critical issues

The consolidation successfully eliminates DRY violations while maintaining full test coverage. The unused code is minor cleanup that doesn't block the PR.

[github-actions]

Summary

Consolidates 7 separate encoding/hashing test files into a single EncodingTests.cs file, reducing ~290 lines of duplicated code while preserving all 18 test cases.

Critical Issues

None found ✅

Suggestions

Remove Unused Test Data Methods

The methods BidirectionalEncodingData() (lines 22-33) and HashData() (lines 40-60) are defined but never used. They appear to be remnants from an attempt at data-driven testing that wasn't completed. Consider removing them to keep the code clean.

Similarly, the EncodingModule class (lines 70-82) is unused and should be removed.

Rationale: The current approach uses concrete module classes (ToBase64Module, FromBase64Module, etc.) which works fine for this test suite. The data-driven infrastructure adds unnecessary complexity without providing value.

Previous Review Status

One previous comment from github-actions bot approves the PR with the same suggestion to remove unused code.

Verdict

✅ APPROVE - No critical issues

The consolidation successfully eliminates DRY violations while maintaining full test coverage. The unused code is minor cleanup that doesn't block the PR.