refactor: Remove redundant code and extract magic numbers#1659
Merged
Conversation
Remove redundant Ordinal string comparisons that are already covered
by OrdinalIgnoreCase checks in ShouldSkipBasedOnHelpText method:
- helpText.Contains("deprecated", StringComparison.Ordinal)
- helpText.Contains("experimental", StringComparison.Ordinal)
Closes #1622
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Replace magic number 5000 with named constant ProgressPrinterGracePeriodMs in PrintProgressExecutor.DisposeAsync to improve code readability and maintainability. Closes #1618 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
thomhurst
temporarily deployed
to
Pull Requests
GitHub Actions
Inactive
Owner
Author
SummaryRemoves redundant case-sensitive string checks and extracts magic number to named constant. Critical IssuesNone found ✅ SuggestionsNone - both changes are straightforward improvements. Verdict✅ APPROVE - No critical issues Change 1: The redundant case-sensitive checks are correctly identified and removed. Change 2: Extracting the magic number |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CliScraperBase.ShouldSkipBasedOnHelpText()that are already covered by case-insensitive checks5000to named constantProgressPrinterGracePeriodMsinPrintProgressExecutorTest plan
Closes #1622, #1618
🤖 Generated with Claude Code