Skip to content

fix: Prevent local NuGet modules from running in CI PR builds #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Dec 30, 2025
Merged

fix: Prevent local NuGet modules from running in CI PR builds #1680

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/ModularPipelines.Build/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
using Microsoft.Extensions.Hosting;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Options;
using ModularPipelines;
using ModularPipelines.Build;
using ModularPipelines.Build.Modules;
using ModularPipelines.Build.Modules.LocalMachine;
Expand Down Expand Up @@ -60,17 +61,28 @@ await PipelineHostBuilder.Create()
new InMemoryCredentialStore(new Credentials(githubToken)));
});

if (context.HostingEnvironment.IsDevelopment())
// Local NuGet modules should only run in local development, not CI
// IsDevelopment() returns true for both local dev AND PR builds in CI (DOTNET_ENVIRONMENT=Development)
// Check common CI environment variables to distinguish local dev from CI
var isRunningInCI = !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("CI"))
|| !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("GITHUB_ACTIONS"))
|| !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("TF_BUILD"))
|| !string.IsNullOrEmpty(Environment.GetEnvironmentVariable("GITLAB_CI"));
var isLocalDevelopment = context.HostingEnvironment.IsDevelopment() && !isRunningInCI;

if (isLocalDevelopment)
{
collection.AddModule<CreateLocalNugetFolderModule>()
.AddModule<AddLocalNugetSourceModule>()
.AddModule<UploadPackagesToLocalNuGetModule>();
}
else
else if (!context.HostingEnvironment.IsDevelopment())
{
// Production environment (main branch CI)
collection.AddModule<UploadPackagesToNugetModule>()
.AddModule<CreateReleaseModule>();
}
// else: CI Development mode (PR builds) - don't register local NuGet or production upload modules
})
.ConfigurePipelineOptions((context, options) => options.DefaultRetryCount = 3)
.SetLogLevel(LogLevel.Debug) // Temporarily hardcoded for debugging
Expand Down
Loading