Skip to content

test: Skip flaky DotNetTests.Has_Not_Errored on CI#1686

Merged
thomhurst merged 1 commit into
mainfrom
fix/flaky-dotnet-test
Dec 30, 2025
Merged

test: Skip flaky DotNetTests.Has_Not_Errored on CI#1686
thomhurst merged 1 commit into
mainfrom
fix/flaky-dotnet-test

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

Summary

  • Skip the DotNetTests.Has_Not_Errored test which is flaky on CI
  • The test runs dotnet list package on the full solution (~100+ projects) which frequently times out
  • This is causing unrelated PRs to fail

Test plan

  • Build passes
  • Other tests continue to run

🤖 Generated with Claude Code

The test runs 'dotnet list package' on the full solution which times out
on CI runners. Skip it similar to Format_Has_Not_Errored.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@thomhurst

Copy link
Copy Markdown
Owner Author

Summary

Skips a flaky test that runs dotnet list package on the full solution (~100+ projects) and frequently times out on CI.

Critical Issues

None found ✅

Suggestions

None - this is a pragmatic approach to prevent unrelated PRs from failing due to CI timeouts. The skip reason is clearly documented, and there's already precedent for this pattern in the same file (see Format_Has_Not_Errored test on line 52).

Verdict

APPROVE - No critical issues

The change is minimal, well-documented, and prevents CI flakiness. If needed, the underlying timeout issue with dotnet list package can be addressed separately without blocking other work.

@thomhurst thomhurst merged commit 3fe70b4 into main Dec 30, 2025
11 of 12 checks passed
@thomhurst thomhurst deleted the fix/flaky-dotnet-test branch December 30, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant