Skip to content

perf: Use HashSet for O(1) secret masking lookups #1723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 1, 2026
Merged

perf: Use HashSet for O(1) secret masking lookups #1723

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions src/ModularPipelines/Engine/BuildSystemSecretMasker.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ internal class BuildSystemSecretMasker : IBuildSystemSecretMasker
private readonly IBuildSystemFormatterProvider _formatterProvider;
private readonly IConsoleWriter _consoleWriter;

private readonly List<string> _alreadyMaskedSecrets = new();
private readonly HashSet<string> _alreadyMaskedSecrets = new();
private readonly object _lock = new();

public BuildSystemSecretMasker(IBuildSystemFormatterProvider formatterProvider,
Expand All @@ -44,9 +44,13 @@ public void MaskSecrets(IEnumerable<string> secrets)
{
var formatter = _formatterProvider.GetFormatter();

foreach (var secret in secrets.Where(s => !_alreadyMaskedSecrets.Contains(s)))
foreach (var secret in secrets)
{
_alreadyMaskedSecrets.Add(secret);
// HashSet.Add returns false if already exists, providing O(1) lookup
if (!_alreadyMaskedSecrets.Add(secret))
{
continue;
}

var maskCommand = formatter.GetMaskSecretCommand(secret);
if (maskCommand != null)
Expand Down
Loading