Skip to content

fix: remove Arguments property deprecation analyzer (MP0010)#2088

Merged
thomhurst merged 1 commit intomainfrom
remove-arguments-deprecated-analyzer
Jan 17, 2026
Merged

fix: remove Arguments property deprecation analyzer (MP0010)#2088
thomhurst merged 1 commit intomainfrom
remove-arguments-deprecated-analyzer

Conversation

@thomhurst
Copy link
Copy Markdown
Owner

Summary

  • Removes the MP0010 analyzer that warned when using the Arguments property on CommandLineToolOptions
  • The Arguments property provides important flexibility for users to customize commands when the typed options class doesn't cover a specific CLI flag
  • This escape hatch is valuable when new CLI features are added before the ModularPipelines model is updated

Test plan

  • Verify the analyzers project builds successfully
  • Verify no MP0010 warnings appear when using the Arguments property

🤖 Generated with Claude Code

The Arguments property provides important flexibility for users to customize
commands when the typed options class doesn't cover a specific CLI flag or
when new CLI features are added before the model is updated.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@thomhurst
Copy link
Copy Markdown
Owner Author

Summary

This PR removes the ArgumentsPropertyDeprecatedAnalyzer (MP0010) analyzer that warned users about using the deprecated Arguments property on CommandLineToolOptions.

Critical Issues

Missing cleanup of auto-generated Resources.Designer.cs

The PR removes entries from Resources.resx (lines 192-199), but Resources.Designer.cs is an auto-generated file that still contains references to the removed resource strings:

  • ArgumentsPropertyDeprecatedAnalyzerTitle (line 281)
  • ArgumentsPropertyDeprecatedAnalyzerMessageFormat (line 290)
  • ArgumentsPropertyDeprecatedAnalyzerDescription (line 299)

These auto-generated properties in Resources.Designer.cs are now orphaned since the source entries were removed from Resources.resx. The Resources.Designer.cs file needs to be regenerated to remove these entries.

Fix: Regenerate Resources.Designer.cs from the updated Resources.resx file, or ensure the build process does this automatically.

Suggestions

None - the removal is straightforward once the regeneration issue is addressed.

Verdict

⚠️ REQUEST CHANGES - The Resources.Designer.cs file needs to be regenerated to remove orphaned references to the deleted analyzer's resource strings.

@thomhurst thomhurst merged commit 7cd55a1 into main Jan 17, 2026
12 checks passed
@thomhurst thomhurst deleted the remove-arguments-deprecated-analyzer branch January 17, 2026 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant