Skip to content

fix: remove Arguments property deprecation analyzer (MP0010) #2088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomhurst merged 1 commit into from
Jan 17, 2026
Merged

fix: remove Arguments property deprecation analyzer (MP0010) #2088

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...larPipelines.Analyzers/ModularPipelines.Analyzers/AnalyzerReleases.Unshipped.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ Rule ID | Category | Severity | Notes
--------|----------|----------|--------------------
AwaitThis | Usage | Error | Prohibit await this in modules
StatefulModule | Design | Warning | Detects mutable instance fields in modules that could leak state between executions
MP0010 | Migration | Warning | Warns when deprecated Arguments property is used on CommandLineToolOptions
MPDEP001 | Usage | Error | DependsOn type does not implement IModule
MPDEP002 | Usage | Error | Circular dependency detected between modules (renamed from ConflictingDependsOnAttribute)
MPDEP003 | Usage | Error | Module depends on itself
Expand Down
107 changes: 0 additions & 107 deletions ...ularPipelines.Analyzers/ModularPipelines.Analyzers/ArgumentsPropertyDeprecatedAnalyzer.cs
View file
Open in desktop

This file was deleted.

9 changes: 0 additions & 9 deletions src/ModularPipelines.Analyzers/ModularPipelines.Analyzers/Resources.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,15 +189,6 @@
<data name="StatefulModuleAnalyzerDescription" xml:space="preserve">
<value>Modules are registered as Singletons in the dependency injection container and can be executed multiple times (retries, sub-modules, parallel pipelines). Instance fields can leak state between executions. Use readonly fields for injected dependencies, or store execution state in IModuleContext.</value>
</data>
<data name="ArgumentsPropertyDeprecatedAnalyzerTitle" xml:space="preserve">
<value>Arguments property is deprecated</value>
</data>
<data name="ArgumentsPropertyDeprecatedAnalyzerMessageFormat" xml:space="preserve">
<value>The 'Arguments' property on '{0}' is deprecated. Use typed positional argument properties instead</value>
</data>
<data name="ArgumentsPropertyDeprecatedAnalyzerDescription" xml:space="preserve">
<value>The Arguments property bypasses type safety. In ModularPipelines v2, use typed positional argument properties marked with [CliArgument] instead. For example, use 'Committish = "HEAD"' on GitRevParseOptions instead of 'Arguments = ["HEAD"]'. If no typed property exists, request one be added or use GenericCommandLineToolOptions.</value>
</data>
<data name="InvalidDependsOnTypeAnalyzerTitle" xml:space="preserve">
<value>Invalid DependsOn type</value>
</data>
Expand Down
Loading