chore(deps): update dependency polly to 8.6.6#2443
Conversation
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6 Dependency Update
This is a straightforward patch version bump for Polly.
Change Summary
- File:
Directory.Packages.props - Change:
Pollyupdated from8.6.5to8.6.6
Assessment
This is a beneficial patch update. The release notes indicate it fixes a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (#2953). Given that ModularPipelines uses Polly for retry policies in module execution, this is a worthwhile fix — deadlocks in scheduling/continuations could manifest as pipeline hangs under specific concurrency conditions.
The change is minimal and correctly uses the centralized Directory.Packages.props approach for version management, which is the right pattern for this repo.
No issues found. Approve and merge.
92b42e2 to
2d7f7b1
Compare
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6 (Follow-up)
A previous review was already posted on this PR — confirming that assessment still stands and no new changes have been introduced since.
Summary
- Single change:
Directory.Packages.propsbumps Polly from8.6.5→8.6.6 - Fix included: Resolves a deadlock in
ScheduledTaskExecutorwhenTrySetResultruns continuations inline (App-vNext/Polly#2953)
Assessment
This is a low-risk, high-value patch update. The deadlock fix is directly relevant to ModularPipelines' use of Polly for retry and resilience policies in parallel module execution — a pipeline hang under concurrent scheduling would be difficult to diagnose and reproduce. Updating is the right call.
The version pin is managed correctly through the centralized Directory.Packages.props file, consistent with the repo's package management approach.
No issues found. Previous review conclusion unchanged: approve and merge.
2d7f7b1 to
90e27e2
Compare
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6 (Review #3)
Two prior reviews have been posted on this PR with identical conclusions. The diff remains unchanged — a single-line version bump in Directory.Packages.props.
Previous reviews addressed: Nothing new to address; no code changes since last review.
Verdict
This patch update fixes a deadlock in ScheduledTaskExecutor (App-vNext/Polly#2953), which is directly relevant to ModularPipelines' parallel module execution. It is a safe, beneficial update managed correctly through the centralized Directory.Packages.props file.
No issues found. Approve and merge.
90e27e2 to
31d7aad
Compare
Code Review: Polly 8.6.5 → 8.6.6 (Review #4)Three prior reviews have been posted on this PR, all reaching the same conclusion. The diff is still unchanged — a single-line version bump in Previous reviews addressed: No new changes since the last review; all prior points remain valid. VerdictThis patch update fixes a deadlock in No issues found. Safe to merge. |
31d7aad to
e0b9f48
Compare
There was a problem hiding this comment.
Code Review
PR: Bump Polly from 8.6.5 → 8.6.6
Summary
This is a minimal, low-risk Renovate Bot patch bump in the centralized package version file (Directory.Packages.props). The change is exactly one line and follows the correct pattern for version management in this repo.
Change Assessment
What changed: Polly 8.6.6 fixes a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (App-vNext/Polly#2953).
Relevance to this project: ModularPipelines makes heavy use of Polly for retry and resilience policies during parallel module execution. A deadlock fix in ScheduledTaskExecutor is directly applicable — this is a meaningful improvement even as a patch release.
Verification Checklist
- Single-line change in the correct centralized location (
Directory.Packages.props) - Patch version bump only — no breaking API changes expected
- Fixes a real bug (deadlock) rather than just a version bump
- Consistent with the repo's NuGet Central Package Management pattern
Verdict
No issues found. This is a beneficial update that resolves a potential deadlock scenario relevant to ModularPipelines' concurrent execution model. Approving.
e0b9f48 to
43b025c
Compare
There was a problem hiding this comment.
Code Review
This is a straightforward Renovate bot dependency update: Polly 8.6.5 → 8.6.6
Change Summary
Single line change in Directory.Packages.props bumping the centrally-managed Polly package version.
Notable Fix in This Release
Polly 8.6.6 includes a targeted bug fix: deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (#2953). This is a patch release with no breaking changes.
Assessment
- The change is minimal and correct — centralized package management via
Directory.Packages.propsis the right pattern for this repo. - The Polly deadlock fix is directly relevant to a pipeline framework like ModularPipelines, which relies heavily on async/concurrent execution with retry policies. Picking up this fix is beneficial.
- No API changes, no migration needed.
Approved — safe to merge.
43b025c to
eea2813
Compare
There was a problem hiding this comment.
Dependency Update Review: Polly 8.6.5 → 8.6.6
This is a straightforward patch bump of the Polly resilience library, updating a single line in Directory.Packages.props.
Change summary: Polly 8.6.5 → 8.6.6
What's in 8.6.6: Fixes a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (App-vNext/Polly#2953). This is a bug fix release with no breaking changes.
Assessment: ✅ This update is safe to merge. The fix addresses a real deadlock scenario that could affect resilience pipeline execution in async contexts — picking it up is the right call. As a patch release, there are no API changes or breaking behaviors to worry about.
eea2813 to
8a489da
Compare
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6
This is a single-line patch bump in Directory.Packages.props, generated by Renovate Bot.
Previous reviews addressed: Multiple prior review cycles have already assessed this PR — all reaching the same conclusion. No new changes have been introduced since those reviews.
Assessment
The update is safe and beneficial. Polly 8.6.6 fixes a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (App-vNext/Polly#2953). This is directly relevant to ModularPipelines, which uses Polly for retry/resilience policies in a parallel async execution model — a scheduling deadlock could cause silent pipeline hangs that are difficult to reproduce.
The version is managed correctly through the centralized Directory.Packages.props file, consistent with the repo's NuGet Central Package Management approach. No API changes or migration steps are needed.
No issues found. Safe to merge.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | ✅ 0 (≤ 20 complexity) |
TIP This summary will be updated as you push new changes. Give us feedback
8a489da to
b3fba8d
Compare
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6
This PR has been reviewed multiple times previously — all with the same conclusion. Nothing has changed in the diff.
Single-line change: Directory.Packages.props bumps Polly from 8.6.5 to 8.6.6.
Key fix: Resolves a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (App-vNext/Polly#2953). This is a patch release with no breaking changes and no migration required.
No issues found. Safe to merge.
b3fba8d to
f4022c3
Compare
There was a problem hiding this comment.
Code Review: Polly 8.6.5 → 8.6.6
This PR has been reviewed multiple times previously with consistent conclusions. The diff remains unchanged.
Change: Single-line patch bump in Directory.Packages.props — Polly 8.6.5 → 8.6.6.
Fix included: Resolves a deadlock in ScheduledTaskExecutor when TrySetResult runs continuations inline (App-vNext/Polly#2953). No breaking changes, no migration required.
Assessment: No issues found. This is a safe, beneficial patch update. The deadlock fix is relevant to ModularPipelines' concurrent async execution model. Safe to merge.
This PR contains the following updates:
8.6.5→8.6.6Release Notes
App-vNext/Polly (Polly)
v8.6.6Compare Source
ScheduledTaskExecutordeadlock whenTrySetResultruns continuations inline by @crnhrv in #2953Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Renovate Bot.