Expose test arguments as filterable properties#5519
Open
SimonCropp wants to merge 3 commits intothomhurst:mainfrom
Open
Expose test arguments as filterable properties#5519SimonCropp wants to merge 3 commits intothomhurst:mainfrom
SimonCropp wants to merge 3 commits intothomhurst:mainfrom
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
Owner
|
Just to avoid redundant work for those who don't need this, and also to not interfere with any possibilities of users having explicitly set these, can we wrap them in a feature flag that the user can control? I added settings functionality in #5522 I'm thinking maybe something like: [Before(HookType.TestDiscovery)]
public static void Configure(BeforeTestDiscoveryContext context)
{
context.Settings.Metadata.EnableArgumentProperties = true;
} |
Owner
|
Also should this work with class constructors too? |
Contributor
Author
for my purposes, i dont need it |
|
Azure Pipelines: 1 pipeline(s) were filtered out due to trigger conditions. |
Parameterized tests can now be filtered by their resolved argument
values via `--treenode-filter`, e.g.:
--treenode-filter "/*/*/MyTests/*[arg0=*foo*]"
TestBuilder.InvokeDiscoveryEventReceiversAsync stringifies each entry
in TestDetails.TestMethodArguments and adds it to the DiscoveredTestContext
as arg0, arg1, ... so it flows into the existing property bag used by
the filter matcher. Wildcards in the value are supported by the platform's
built-in matcher.
b715cf4 to
d176ec6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parameterized tests can now be filtered by their resolved argument
values via
--treenode-filter, e.g.:TestBuilder.InvokeDiscoveryEventReceiversAsync stringifies each entry
in TestDetails.TestMethodArguments and adds it to the DiscoveredTestContext
as arg0, arg1, ... so it flows into the existing property bag used by
the filter matcher. Wildcards in the value are supported by the platform's
built-in matcher.