replace Text with TextTtf, added TextOtf#35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR splits the previous generic text example into a TrueType-specific example and a new OpenType-specific example, so the examples repo can showcase both font formats as ThorVG adds OTF support.
Changes:
- Renames/refines the TTF example content in
TextTtf.cpp, mainly updating labels and layout. - Adds a new
TextOtf.cppexample that mirrors the text feature showcase using.otffonts. - Updates
src/meson.buildto buildTextTtfandTextOtfinstead of the previous singleTextexample.
Reviewed changes
Copilot reviewed 3 out of 7 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/TextTtf.cpp |
Adjusts the existing TTF demo’s displayed text and vertical spacing. |
src/TextOtf.cpp |
Adds a full new OpenType demo, including file-backed and memory-backed font loading. |
src/meson.build |
Replaces the old text example target with separate TTF/OTF example targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dependency: thorvg/thorvg#4370