Skip to content

lottie: add lottie audio sample#37

Draft
tinyjin wants to merge 1 commit into
mainfrom
jinny/audio-layer
Draft

lottie: add lottie audio sample#37
tinyjin wants to merge 1 commit into
mainfrom
jinny/audio-layer

Conversation

@tinyjin
Copy link
Copy Markdown
Member

@tinyjin tinyjin commented May 20, 2026

Used miniaudio for sample's audio playback, is a single source file library supporting all major platforms.

CleanShot.2026-05-20.at.18.29.51.mp4

see: https://github.com/mackron/miniaudio

Used miniaudio for sample's audio playback, is a single source file library supporting all major platforms.

see: https://github.com/mackron/miniaudio
@tinyjin tinyjin self-assigned this May 20, 2026
@tinyjin tinyjin requested a review from hermet as a code owner May 20, 2026 09:24
Copilot AI review requested due to automatic review settings May 20, 2026 09:24
@tinyjin tinyjin added the enhancement Improve examples label May 20, 2026
@tinyjin tinyjin marked this pull request as draft May 20, 2026 09:24
@tinyjin
Copy link
Copy Markdown
Member Author

tinyjin commented May 20, 2026

Draft until audio merged:
thorvg/thorvg#4402

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@hermet
Copy link
Copy Markdown
Member

hermet commented May 21, 2026

@tinyjin Let’s remove the audio library dependency here. Instead, please just output event logs for the audio trigger points. Thanks. (you can build an test app for audio like thorvg janitor with separate project)

@tinyjin
Copy link
Copy Markdown
Member Author

tinyjin commented May 21, 2026

@hermet Thanks I will separate them with your suggestion, and update that repo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Improve examples

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants