Formatting ISBN with hyphen

thiagolepidus · thiagolepidus · commit 2abe0dc9b584 · 2025-05-15T17:30:45.000-04:00
Issue: documentacao-e-tarefas/desenvolvimento_e_infra#1002

Signed-off-by: Thiago Brasil &lt;thiago@lepidus.com.br&gt;
diff --git a/classes/factories/ThothPublicationFactory.inc.php b/classes/factories/ThothPublicationFactory.inc.php
@@ -72,7 +72,13 @@ private function getIsbnByPublicationFormat($publicationFormat)
         $identificationCodes = $publicationFormat->getIdentificationCodes()->toArray();
         foreach ($identificationCodes as $identificationCode) {
             if ($identificationCode->getCode() == '15' || $identificationCode->getCode() == '24') {
-                return $identificationCode->getValue();
+                $isbn = $identificationCode->getValue();
+                try {
+                    $isbn13 = \Biblys\Isbn\Isbn::convertToIsbn13($isbn);
+                    return str_replace('-', '', $isbn13) === $isbn ? $isbn13 : $isbn;
+                } catch (Exception $e) {
+                    return $isbn;
+                }
             }
         }
 

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,13 @@ private function getIsbnByPublicationFormat($publicationFormat)`
`72`	`72`	`$identificationCodes = $publicationFormat->getIdentificationCodes()->toArray();`
`73`	`73`	`foreach ($identificationCodes as $identificationCode) {`
`74`	`74`	`if ($identificationCode->getCode() == '15' \|\| $identificationCode->getCode() == '24') {`
`75`		`- return $identificationCode->getValue();`
	`75`	`+ $isbn = $identificationCode->getValue();`
	`76`	`+ try {`
	`77`	`+ $isbn13 = \Biblys\Isbn\Isbn::convertToIsbn13($isbn);`
	`78`	`+ return str_replace('-', '', $isbn13) === $isbn ? $isbn13 : $isbn;`
	`79`	`+ } catch (Exception $e) {`
	`80`	`+ return $isbn;`
	`81`	`+ }`
`76`	`82`	`}`
`77`	`83`	`}`
`78`	`84`