Merge branch 'format_isbn_3_4_0-1002' into 'main'

Formatting ISBN with hyphens

See merge request softwares-pkp/plugins_ojs/thoth-omp-plugin!81

Author: thiagolepidus

classes/factories/ThothPublicationFactory.inc.php

@@ -72,7 +72,13 @@ private function getIsbnByPublicationFormat($publicationFormat)
         $identificationCodes = $publicationFormat->getIdentificationCodes()->toArray();
         foreach ($identificationCodes as $identificationCode) {
             if ($identificationCode->getCode() == '15' || $identificationCode->getCode() == '24') {
-                return $identificationCode->getValue();
+                $isbn = $identificationCode->getValue();
+                try {
+                    $isbn13 = \Biblys\Isbn\Isbn::convertToIsbn13($isbn);
+                    return str_replace('-', '', $isbn13) === $isbn ? $isbn13 : $isbn;
+                } catch (Exception $e) {
+                    return $isbn;
+                }
             }
         }
 

classes/services/ThothBookService.inc.php

@@ -90,15 +90,12 @@ public function validate($publication)
         }
 
         $publicationFormats = DAORegistry::getDAO('PublicationFormatDAO')
-            ->getApprovedByPublicationId($publication->getId())
-            ->toArray();
+            ->getByPublicationId($publication->getId());
         foreach ($publicationFormats as $publicationFormat) {
-            if ($publicationFormat->getIsAvailable()) {
-                $errors = array_merge(
-                    $errors,
-                    ThothService::publication()->validate($publicationFormat)
-                );
-            }
+            $errors = array_merge(
+                $errors,
+                ThothService::publication()->validate($publicationFormat)
+            );
         }
 
         return $errors;

composer.lock

@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.2.8.0</release>
-	<date>2025-05-01</date>
+	<release>0.2.8.1</release>
+	<date>2025-05-15</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>