Merge pull request #42 from lepidus/stable-3_3_0

fix/prevents registration of publications without related files (OMP 3.3.0)

Author: thiagolepidus

.gitlab-ci.yml

@@ -14,6 +14,10 @@ include:
     - git submodule update --init --depth 1
     - composer install
 
-unit_test_php_7_3:
+plugin_unit_test_php_7_3:
   rules:
     - when: never
+
+application_unit_test_php_7_3:
+  rules:
+    - when: never

classes/api/ThothEndpoint.inc.php

@@ -93,6 +93,7 @@ public function register($slimRequest, $response, $args)
         try {
             $thothBookService = ThothService::book();
             $thothBookId = $thothBookService->register($publication, $thothImprintId);
+            $thothBookService->setActive();
             $submission = Services::get('submission')->edit($submission, ['thothWorkId' => $thothBookId], $request);
             $this->handleNotification($request, $submission, true, $disableNotification);
         } catch (QueryException $e) {

classes/listeners/PublicationPublishListener.inc.php

@@ -55,6 +55,7 @@ public function registerThothBook($hookName, $args)
         try {
             $thothBookService = ThothService::book();
             $thothBookId = $thothBookService->register($publication, $thothImprintId);
+            $thothBookService->setActive();
             $submission = Services::get('submission')->edit($submission, ['thothWorkId' => $thothBookId], $request);
             $thothNotification->notifySuccess($request, $submission);
         } catch (QueryException $e) {

classes/services/ThothBookService.inc.php

@@ -22,6 +22,8 @@ class ThothBookService
 {
     public $factory;
     public $repository;
+
+    private $originalThothBook;
     private $registeredEntryId;
 
     public function __construct($factory, $repository)
@@ -30,6 +32,16 @@ public function __construct($factory, $repository)
         $this->repository = $repository;
     }
 
+    public function getOriginalThothBook()
+    {
+        return $this->originalThothBook;
+    }
+
+    public function setOriginalThothBook($originalThothBook)
+    {
+        $this->originalThothBook = $originalThothBook;
+    }
+
     public function getRegisteredEntryId()
     {
         return $this->registeredEntryId;
@@ -45,6 +57,11 @@ public function register($publication, $thothImprintId)
         $thothBook = $this->factory->createFromPublication($publication);
         $thothBook->setImprintId($thothImprintId);
 
+        if ($thothBook->getWorkStatus() === ThothWork::WORK_STATUS_ACTIVE) {
+            $this->setOriginalThothBook($thothBook);
+            $thothBook->setWorkStatus(ThothWork::WORK_STATUS_FORTHCOMING);
+        }
+
         $thothBookId = $this->repository->add($thothBook);
         $publication->setData('thothBookId', $thothBookId);
         $this->setRegisteredEntryId($thothBookId);
@@ -122,4 +139,15 @@ public function deleteRegisteredEntry()
         $this->repository->delete($this->getRegisteredEntryId());
         $this->setRegisteredEntryId(null);
     }
+
+    public function setActive()
+    {
+        if ($this->getOriginalThothBook() === null) {
+            return;
+        }
+
+        $originalThothBook = $this->getOriginalThothBook();
+        $originalThothBook->setWorkStatus(ThothWork::WORK_STATUS_ACTIVE);
+        $this->repository->edit($originalThothBook);
+    }
 }

classes/services/ThothPublicationService.inc.php

@@ -53,6 +53,10 @@ public function registerByPublication($publication)
             ->getByPublicationId($publication->getId())
             ->toArray();
         foreach ($publicationFormats as $publicationFormat) {
+            if (!$this->canRegister($publicationFormat)) {
+                continue;
+            }
+
             $this->register($publicationFormat, $thothBookId);
         }
     }
@@ -107,4 +111,23 @@ public function validate($publicationFormat)
 
         return $errors;
     }
+
+    private function canRegister($publicationFormat)
+    {
+        if ($publicationFormat->getPhysicalFormat()) {
+            return true;
+        }
+
+        $submissionFiles = array_filter(
+            iterator_to_array(Services::get('submissionFile')->getMany([
+                'assocTypes' => [ASSOC_TYPE_PUBLICATION_FORMAT],
+                'assocIds' => [$publicationFormat->getId()],
+            ])),
+            function ($submissionFile) {
+                return $submissionFile->getData('chapterId') == null;
+            }
+        );
+
+        return count($submissionFiles) > 0 || !empty($publicationFormat->getRemoteUrl());
+    }
 }

version.xml

@@ -3,8 +3,8 @@
 <version>
 	<application>thoth</application>
 	<type>plugins.generic</type>
-	<release>0.1.10.2</release>
-	<date>2025-06-16</date>
+	<release>0.1.10.3</release>
+	<date>2025-08-04</date>
 	<lazy-load>1</lazy-load>
 	<class>ThothPlugin</class>
 </version>