Fix clippy::unnecessary_sort_by

Author: ja573

thoth-export-server/src/bibtex/bibtex_thoth.rs

@@ -123,7 +123,7 @@ impl TryFrom<Work> for BibtexThothEntry {
 
         let mut contributions = work.contributions;
         // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-        contributions.sort_by(|a, b| a.contribution_ordinal.cmp(&b.contribution_ordinal));
+        contributions.sort_by_key(|a| a.contribution_ordinal);
         let (author, editor) = extract_authors_and_editors(contributions)?;
 
         let shorttitle = work.titles[0]

thoth-export-server/src/csv/csv_thoth.rs

@@ -110,7 +110,7 @@ impl From<Work> for CsvThothRow {
     fn from(work: Work) -> Self {
         let mut subjects = work.subjects;
         // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-        subjects.sort_by(|a, b| a.subject_ordinal.cmp(&b.subject_ordinal));
+        subjects.sort_by_key(|a| a.subject_ordinal);
         CsvThothRow {
             publisher: work.imprint.publisher.publisher_name,
             imprint: work.imprint.imprint_name,

thoth-export-server/src/csv/kbart_oclc.rs

@@ -120,7 +120,7 @@ impl TryFrom<Work> for KbartOclcRow {
         // but this is not guaranteed, so we select the highest-ranked contributor of the
         // appropriate contribution type who is listed as a "main" contributor.
         // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-        contributions.sort_by(|a, b| a.contribution_ordinal.cmp(&b.contribution_ordinal));
+        contributions.sort_by_key(|a| a.contribution_ordinal);
         for contribution in contributions {
             if contribution.main_contribution {
                 if work.work_type == WorkType::EDITED_BOOK {

thoth-export-server/src/marc21/marc21record_thoth.rs

@@ -571,7 +571,7 @@ fn toc_field(relations: &[WorkRelations]) -> ThothResult<FieldRepr> {
         ));
     }
     // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-    chapters.sort_by(|a, b| a.relation_ordinal.cmp(&b.relation_ordinal));
+    chapters.sort_by_key(|a| a.relation_ordinal);
     let mut chapter_list = chapters.iter().peekable();
     let mut toc_field: FieldRepr = FieldRepr::from((b"505", "00"));
     let mut separator = " --";

thoth-export-server/src/xml/doideposit_crossref.rs

@@ -138,7 +138,7 @@ impl XmlElementBlock<DoiDepositCrossref> for Work {
 
                 let mut chapters = self.relations.clone();
                 // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-                chapters.sort_by(|a, b| a.relation_ordinal.cmp(&b.relation_ordinal));
+                chapters.sort_by_key(|a| a.relation_ordinal);
                 for chapter in chapters
                     .iter()
                     .filter(|r| r.relation_type == RelationType::HAS_CHILD)

thoth-export-server/src/xml/onix3_google_books.rs

@@ -296,9 +296,8 @@ impl XmlElementBlock<Onix3GoogleBooks> for Work {
                         .any(|c| c.contribution_type.eq(&ContributionType::AUTHOR))
                     {
                         // WorkQuery should already have retrieved these sorted by ordinal, but sort again for safety
-                        contributions
-                            .sort_by(|a, b| a.contribution_ordinal.cmp(&b.contribution_ordinal));
-                        contributions.sort_by(|a, b| b.main_contribution.cmp(&a.main_contribution));
+                        contributions.sort_by_key(|a| a.contribution_ordinal);
+                        contributions.sort_by_key(|b| std::cmp::Reverse(b.main_contribution));
                         contributions[0].contribution_type = ContributionType::AUTHOR;
                     }
                     for contribution in &contributions {