Revert "Add support for custom validation contexts in resource creation and update"

This reverts commit fea2bb7.

Author: goosys

app/controllers/administrate/application_controller.rb

@@ -57,7 +57,7 @@ def create
         contextualize_resource(resource)
       end
 
-      if resource.save(context: validation_contexts_on_create(resource))
+      if resource.save
         yield(resource) if block_given?
         redirect_to(
           after_resource_created_path(resource),
@@ -73,9 +73,7 @@ def create
     end
 
     def update
-      requested_resource.assign_attributes(resource_params)
-
-      if requested_resource.save(context: validation_contexts_on_update(requested_resource))
+      if requested_resource.update(resource_params)
         redirect_to(
           after_resource_updated_path(requested_resource),
           notice: translate_with_resource("update.success"),
@@ -316,26 +314,6 @@ def authorize_resource(resource)
     def contextualize_resource(resource)
     end
 
-    # Override this if you want to provide additional validation contexts.
-    #
-    # @param resource [ActiveRecord::Base] The resource to be validated.
-    # @return [Array<Symbol>] The validation contexts to be used.
-    def validation_contexts_on_create(resource)
-      default_validation_contexts(resource)
-    end
-
-    # Override this if you want to provide additional validation contexts.
-    #
-    # @param resource [ActiveRecord::Base] The resource to be validated.
-    # @return [Array<Symbol>] The validation contexts to be used.
-    def validation_contexts_on_update(resource)
-      default_validation_contexts(resource)
-    end
-
-    def default_validation_contexts(resource)
-      resource.new_record? ? [:create] : [:update]
-    end
-
     def paginate_resources(resources)
       resources.page(params[:_page]).per(records_per_page)
     end

docs/customizing_controller_actions.md

@@ -117,30 +117,3 @@ def create
   end
 end
 ```
-
-## Validation Contexts
-
-You can customize the context when saving a resource in the controller.  
-For example, with the following settings, regular admins are required to input a name, but super admins can update the resource *without* a name.
-
-```ruby
-# Model
-validates :name, presence: true, on: :save_by_regular_admin
-
-# Controller
-def validation_contexts_on_create(resource)
-  if current_user.super_admin?
-    super + [:save_by_super_admin]
-  else
-    super + [:save_by_regular_admin]
-  end
-end
-
-def validation_contexts_on_update(resource)
-  if current_user.super_admin?
-    super + [:save_by_super_admin]
-  else
-    super + [:save_by_regular_admin]
-  end
-end
-```

spec/controllers/admin/application_controller_spec.rb

@@ -192,38 +192,4 @@ def resource_resolver
       end
     end
   end
-
-  describe "validation contexts" do
-    render_views
-    controller(Admin::ProductsController) do
-      def validation_contexts_on_create(resource)
-        super + [:some_unclear_situation]
-      end
-
-      def validation_contexts_on_update(resource)
-        super + [:some_unclear_situation]
-      end
-    end
-
-    context "on create" do
-      it "raise a validation error due to custom validation context" do
-        params = attributes_for(:product)
-        post :create, params: {product: params}
-
-        expect(response).to have_http_status(:unprocessable_entity)
-        expect(response.body).to include("Product meta tag can't be blank")
-      end
-    end
-
-    context "on update" do
-      it "raise a validation error due to custom validation context" do
-        product = create(:product, product_meta_tag: nil)
-        params = {name: "New Name"}
-        put :update, params: {id: product.to_param, product: params}
-
-        expect(response).to have_http_status(:unprocessable_entity)
-        expect(response.body).to include("Product meta tag can't be blank")
-      end
-    end
-  end
 end