Skip to content

Remove unused authentication generator file#544

Open
jeromedalbert wants to merge 1 commit intothoughtbot:mainfrom
jeromedalbert:remove-unused-file
Open

Remove unused authentication generator file#544
jeromedalbert wants to merge 1 commit intothoughtbot:mainfrom
jeromedalbert:remove-unused-file

Conversation

@jeromedalbert
Copy link
Copy Markdown

@jeromedalbert jeromedalbert commented Sep 7, 2025

Follow-up to #542.

Remove the unused lib/generators/factory_bot/authentication/templates/users.rb file.

When using the authentication generator, we generate a users.rb file with the following values:

def attributes
[
FixedAttribute.new(:email_address, "user@example.com"),
FixedAttribute.new(:password, "password")
]
end

And this is expected behavior:

And the file "spec/factories/users.rb" should contain exactly:
"""
FactoryBot.define do
factory :user do
email_address { "user@example.com" }
password { "password" }
end
end
"""

So the values of lib/generators/factory_bot/authentication/templates/users.rb are never used. This cleanup PR removes the file.

Copy link
Copy Markdown
Member

@neilvcarvalho neilvcarvalho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants