fix: add telnetlib3 and setuptools to requirements.txt#900
Closed
mitre88 wants to merge 3 commits into
Closed
Conversation
added 3 commits
April 20, 2026 19:00
telnetlib is no longer a standard module in Python 3.13+ and needs to be imported from the telnetlib3 package instead. Fixes threat9#892
DSA/DSS keys are no longer supported in modern paramiko (removed in v4.0). Skip DSA keys with an error message instead of crashing. Fixes threat9#898
The wildcard import may not work correctly with all pysnmp versions. Explicitly import the required classes: SnmpEngine, CommunityData, UdpTransportTarget, ContextData, ObjectType, ObjectIdentity, get_cmd. Fixes threat9#885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
telnetlib is no longer a standard module in Python 3.13+. The code in routersploit/core/exploit/shell.py already handles this by importing telnetlib3 as a fallback when telnetlib is not available.
This PR adds the missing dependencies to requirements.txt.
Changes
requirements.txt
Added:
Fixes #892