fix: replace bare except Exception with specific ftplib exceptions#902
Open
mitre88 wants to merge 1 commit into
Open
fix: replace bare except Exception with specific ftplib exceptions#902mitre88 wants to merge 1 commit into
mitre88 wants to merge 1 commit into
Conversation
… FTP client Using broad except Exception clauses can mask errors and make debugging difficult. Replaced with ftplib.all_errors which is the appropriate exception type for FTP operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced bare except Exception clauses with specific ftplib.all_errors exceptions in the FTP client.
Why
Using broad except Exception clauses can mask errors and make debugging difficult. The ftplib.all_errors tuple is the appropriate exception type for FTP operations.
Changes
Affects: routersploit/core/ftp/ftp_client.py