[pull] master from apify:master#186
Merged
pull[bot] merged 1 commit intothreatcode:masterfrom Apr 28, 2026
Merged
Conversation
When page.goto throws "Download is starting", Playwright has already
captured the file — but the Download object was inaccessible to
user-land code. The only workaround was re-downloading via HTTP, which
breaks on sites requiring a
browser session (e.g. ECAS-gated resources on Eur-Lex).
This PR adds a downloads: Download[] array to PlaywrightCrawlingContext,
populated via page.on('download', ...)
registered in _enhanceCrawlingContextWithPageInfo — before navigation,
so downloads triggered by page.goto are always
captured.
Closes #3583
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )