Skip to content

Commit 336e713

Browse files
cliffordgamajacobtylerwalls
authored andcommitted
Refs #36438 -- Simplified retrieval of GeneratedField base fields in migrations autodetector.
This was creating an unusable Q object solely to call referenced_base_fields on it.
1 parent 5ee651f commit 336e713

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

django/db/migrations/autodetector.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1682,7 +1682,10 @@ def _get_dependencies_for_foreign_key(app_label, model_name, field, project_stat
16821682

16831683
def _get_dependencies_for_generated_field(self, field):
16841684
dependencies = []
1685-
referenced_base_fields = models.Q(field.expression).referenced_base_fields
1685+
referenced_base_fields = [
1686+
name
1687+
for name, *lookups in models.Model._get_expr_references(field.expression)
1688+
]
16861689
newly_added_fields = sorted(self.new_field_keys - self.old_field_keys)
16871690
for app_label, model_name, added_field_name in newly_added_fields:
16881691
added_field = self.to_state.models[app_label, model_name].get_field(

0 commit comments

Comments
 (0)