Skip to content

Commit 9391bee

Browse files
Fixed #37020 -- Removed guidance to edit fetched .po files by hand.
Altering the .po files by hand was causing incorrect line numbers and plural forms. Since our fetching procedure does not recompile any hand-edited .po files to .mo files for production use, just accept Transifex's plural forms as a source of truth. https://forum.djangoproject.com/t/discourage-releasers-from-editing-po-files-by-hand/44441
1 parent 4d8cc40 commit 9391bee

1 file changed

Lines changed: 1 addition & 14 deletions

File tree

docs/internals/howto-release-django.txt

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -210,10 +210,7 @@ A few days before any release
210210
for the new release; this will be in ``docs/releases/index.txt``.
211211

212212
#. If this is a :term:`feature release`, ensure translations from Transifex
213-
have been integrated. This is typically done by a separate translation's
214-
manager rather than the releaser, but here are the steps. This process is a
215-
bit lengthy so be sure to set aside 4-10 hours to do this, and ideally plan
216-
for this task one or two days ahead of the release day.
213+
have been integrated.
217214

218215
In addition to having a configured Transifex account, ensure that the `tx
219216
CLI <https://developers.transifex.com/docs/cli>`_ is available in your
@@ -240,12 +237,6 @@ A few days before any release
240237

241238
$ git diff --name-only stable/5.0.x | grep "\.po" | xargs sed -ri "s/PO-Revision-Date: [0-9\-]+ /PO-Revision-Date: $(date -I) /g"
242239

243-
All the new ``.po`` files should be manually and carefully inspected to
244-
avoid committing a change in a file without any new translations. Also,
245-
there shouldn't be any changes in the "plural forms": if there are any
246-
(usually Spanish and French report changes for this) those will need
247-
reverting.
248-
249240
Lastly, commit the changed/added files (both ``.po`` and ``.mo``) and create
250241
a new PR targeting the stable branch of the corresponding release (example
251242
`PR updating translations for 4.2
@@ -731,10 +722,6 @@ You're almost done! All that's left to do now is:
731722
$ django-admin makemessages -l en --domain=djangojs
732723
processing locale en
733724

734-
#. Review the diff before pushing and avoid committing changes to the
735-
``.po`` files without any new translations (:commit:`example commit
736-
<d2b1ec551567c208abfdd21b27ff6d08ae1a6371>`).
737-
738725
#. Make a pull request against the corresponding stable branch and merge
739726
once approved.
740727

0 commit comments

Comments
 (0)