Skip to content

Commit a49be25

Browse files
timgrahamnessita
authored andcommitted
Moved QuerySet.extra() assertions to a separate test.
This allows backends that don't support extra() to skip it.
1 parent c63591d commit a49be25

1 file changed

Lines changed: 8 additions & 3 deletions

File tree

tests/queries/tests.py

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -897,14 +897,19 @@ def test_ticket7235(self):
897897
self.assertSequenceEqual(q.annotate(Count("food")), [])
898898
self.assertSequenceEqual(q.order_by("meal", "food"), [])
899899
self.assertSequenceEqual(q.distinct(), [])
900-
self.assertSequenceEqual(q.extra(select={"foo": "1"}), [])
901900
self.assertSequenceEqual(q.reverse(), [])
901+
self.assertSequenceEqual(q.defer("meal"), [])
902+
self.assertSequenceEqual(q.only("meal"), [])
903+
904+
def test_ticket7235_extra(self):
905+
Eaten.objects.create(meal="m")
906+
q = Eaten.objects.none()
907+
with self.assertNumQueries(0):
908+
self.assertSequenceEqual(q.extra(select={"foo": "1"}), [])
902909
q.query.low_mark = 1
903910
msg = "Cannot change a query once a slice has been taken."
904911
with self.assertRaisesMessage(TypeError, msg):
905912
q.extra(select={"foo": "1"})
906-
self.assertSequenceEqual(q.defer("meal"), [])
907-
self.assertSequenceEqual(q.only("meal"), [])
908913

909914
def test_ticket7791(self):
910915
# There were "issues" when ordering and distinct-ing on fields related

0 commit comments

Comments
 (0)